[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88628=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88628 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 06/Apr/18 22:22 Start Date: 06/Apr/18 22:22 Worklog Time Spent: 10m Work Description: aaltay commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379400320 I will merge this based on passed gradle python precommit tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88628) Time Spent: 1.5h (was: 1h 20m) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File >
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88629=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88629 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 06/Apr/18 22:22 Start Date: 06/Apr/18 22:22 Worklog Time Spent: 10m Work Description: aaltay closed pull request #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/sdks/python/apache_beam/runners/direct/executor.py b/sdks/python/apache_beam/runners/direct/executor.py index 107f00764a2..8ab30b4046c 100644 --- a/sdks/python/apache_beam/runners/direct/executor.py +++ b/sdks/python/apache_beam/runners/direct/executor.py @@ -274,6 +274,7 @@ def __init__(self, transform_evaluator_registry, evaluation_context, self._input_bundle = input_bundle # For non-empty bundles, store the window of the max EOW. # TODO(mariagh): Move to class _Bundle's inner _StackedWindowedValues +self._latest_main_input_window = None if input_bundle.has_elements(): self._latest_main_input_window = input_bundle._elements[0].windows[0] for elem in input_bundle.get_elements_iterable(): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88629) Time Spent: 1h 40m (was: 1.5h) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88609=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88609 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 06/Apr/18 20:57 Start Date: 06/Apr/18 20:57 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379376088 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88609) Time Spent: 1h 20m (was: 1h 10m) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88573=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88573 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 06/Apr/18 19:16 Start Date: 06/Apr/18 19:16 Worklog Time Spent: 10m Work Description: aaltay commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379350953 Thank you. I will merge once tests here pass. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88573) Time Spent: 1h 10m (was: 1h) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File >
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88565=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88565 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 06/Apr/18 18:45 Start Date: 06/Apr/18 18:45 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379342317 @aaltay: I have filed https://issues.apache.org/jira/browse/BEAM-4029 for adding additional tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88565) Time Spent: 1h (was: 50m) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File >
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88564 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 06/Apr/18 18:44 Start Date: 06/Apr/18 18:44 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379342182 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88564) Time Spent: 50m (was: 40m) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88269=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88269 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 05/Apr/18 23:10 Start Date: 05/Apr/18 23:10 Worklog Time Spent: 10m Work Description: aaltay commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379103223 Thank you LGTM. Should we run at least some batch unit tests with BundleBasedDirectRunner to prevent regressions? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88269) Time Spent: 40m (was: 0.5h) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File >
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88264=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88264 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 05/Apr/18 22:52 Start Date: 05/Apr/18 22:52 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379099988 R: @aaltay CC: @mariapython This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88264) Time Spent: 0.5h (was: 20m) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", >
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88263=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88263 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 05/Apr/18 22:52 Start Date: 05/Apr/18 22:52 Worklog Time Spent: 10m Work Description: charlesccychen commented on issue #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035#issuecomment-379099988 R: @aaltay This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88263) Time Spent: 20m (was: 10m) > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in
[jira] [Work logged] (BEAM-4024) BundleBasedDirectRunner fails with recent side input changes
[ https://issues.apache.org/jira/browse/BEAM-4024?focusedWorklogId=88262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88262 ] ASF GitHub Bot logged work on BEAM-4024: Author: ASF GitHub Bot Created on: 05/Apr/18 22:51 Start Date: 05/Apr/18 22:51 Worklog Time Spent: 10m Work Description: charlesccychen opened a new pull request #5035: [BEAM-4024] Fix AttributeError in BundleBasedDirectRunner URL: https://github.com/apache/beam/pull/5035 This change fixes an AttributeError in the BundleBasedDirectRunner. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88262) Time Spent: 10m Remaining Estimate: 0h > BundleBasedDirectRunner fails with recent side input changes > > > Key: BEAM-4024 > URL: https://issues.apache.org/jira/browse/BEAM-4024 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core >Reporter: Charles Chen >Assignee: Charles Chen >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Recently, changes were made to support streaming side inputs in the Beam > Python DirectRunner ([https://github.com/apache/incubator-beam/pull/4838] and > [https://github.com/apache/beam/pull/4949]). However, these changes cause > problems when the BundleBasedDirectRunner is explicitly used. When Beam > Python tests are run with the BundleBasedDirectRunner (i.e. when the > FnApiRunner is disabled), the following errors occur: > == > FAIL: test_empty_write (apache_beam.io.filebasedsink_test.TestFileBasedSink) > -- > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/io/filebasedsink_test.py", > line 159, in test_empty_write > p | beam.Create([]) | beam.io.Write(sink) # pylint: > disable=expression-not-assigned > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/pipeline.py", > line 409, in __exit__ > self.run().wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/testing/test_pipeline.py", > line 104, in run > state = result.wait_until_finish() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/direct_runner.py", > line 421, in wait_until_finish > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 360, in await_completion > self._executor.await_completion() > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 406, in await_completion > six.reraise(t, v, tb) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 346, in attempt_call > self._completion_callback.handle_result(self, self._input_bundle, result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 238, in handle_result > input_committed_bundle, self._timer_firings, transform_result) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 242, in handle_result > committed_bundle.get_elements_iterable(make_copy=True)) > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/evaluation_context.py", > line 97, in add_values > assert not view.has_result > AssertionError: > >> begin captured logging << > root: INFO: Missing pipeline option (runner). Executing pipeline using the > default runner: DirectRunner. > root: INFO: Running pipeline with DirectRunner. > root: DEBUG: Creating 1 empty shard(s). > root: INFO: Starting finalize_write threads with num_shards: 1 (skipped: 0), > batches: 1, num_threads: 1 > root: INFO: Renamed 1 shards in 0.11 seconds. > root: ERROR: Exception at bundle > , > due to an exception. > Traceback (most recent call last): > File > "/usr/local/google/home/ccy/git/beam/sdks/python/apache_beam/runners/direct/executor.py", > line 307, in call > side_input_values) > File >
