[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104689=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104689 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 22/May/18 17:04 Start Date: 22/May/18 17:04 Worklog Time Spent: 10m Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-391066956 Thanks for this. I can see from the [Gradle build scan](https://scans.gradle.com/s/zehazergdsv7q) that tests such as ` ParDoTest$TimerTests` are now being run. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104689) Time Spent: 1.5h (was: 1h 20m) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 1.5h > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104435=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104435 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 22/May/18 01:28 Start Date: 22/May/18 01:28 Worklog Time Spent: 10m Work Description: jkff commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390833995 Ugh, forgot the debugging leftover where I was ensuring that ValidatesRunner tests run at all by throwing an exception. Now they do, and the exception failed Flink ValidatesRunner, WAI. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104435) Time Spent: 1h 20m (was: 1h 10m) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 1h 20m > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104334=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104334 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 23:27 Start Date: 21/May/18 23:27 Worklog Time Spent: 10m Work Description: jkff commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390813643 Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104334) Time Spent: 1h 10m (was: 1h) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 1h 10m > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104230=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104230 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 20:14 Start Date: 21/May/18 20:14 Worklog Time Spent: 10m Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390768667 Yikes, good catch, and thanks for putting together a fix. In general looks good to me. I checked to verify there are no other references to `Enclosed.class` in the codebase (`git grep Enclosed`). I kicked off Flink + Dataflow ValidatesRunner tests so we can verify that the tests actually get run. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104230) Time Spent: 1h (was: 50m) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 1h > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104225=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104225 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 20:12 Start Date: 21/May/18 20:12 Worklog Time Spent: 10m Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390768230 Run Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104225) Time Spent: 0.5h (was: 20m) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 0.5h > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104227=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104227 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 20:12 Start Date: 21/May/18 20:12 Worklog Time Spent: 10m Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390768294 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104227) Time Spent: 50m (was: 40m) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 50m > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104226=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104226 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 20:12 Start Date: 21/May/18 20:12 Worklog Time Spent: 10m Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390768267 Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104226) Time Spent: 40m (was: 0.5h) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 40m > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104224=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104224 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 20:12 Start Date: 21/May/18 20:12 Worklog Time Spent: 10m Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-390768230 Run Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104224) Time Spent: 20m (was: 10m) > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 20m > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104212=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104212 ] ASF GitHub Bot logged work on BEAM-4375: Author: ASF GitHub Bot Created on: 21/May/18 19:58 Start Date: 21/May/18 19:58 Worklog Time Spent: 10m Work Description: jkff opened a new pull request #5440: [BEAM-4375] Replaces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440 RunWith(Enclosed.class) causes tests to be skipped https://github.com/gradle/gradle/issues/2985 (in this PR I also fixed MetricsTests which was actually failing). RunWith(Suite.class) causes them to be duplicated https://github.com/gradle/gradle/issues/5484 . R: @swegner This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104212) Time Spent: 10m Remaining Estimate: 0h > Gradle doesn't run tests under RunWith(Enclosed.class) > -- > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Eugene Kirpichov >Assignee: Scott Wegner >Priority: Blocker > Time Spent: 10m > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at > the produced test report, one can see that it is missing tests that have > RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > > This is very very bad - some of these tests are already known to be > (silently) broken. > > Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency > measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
