[jira] [Work logged] (BEAM-4764) Task :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses broken
[
https://issues.apache.org/jira/browse/BEAM-4764?focusedWorklogId=121960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121960
]
ASF GitHub Bot logged work on BEAM-4764:
Author: ASF GitHub Bot
Created on: 11/Jul/18 17:15
Start Date: 11/Jul/18 17:15
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5929: [BEAM-4764] Fix
java precommit to ensure that any checks in model/* are run.
URL: https://github.com/apache/beam/pull/5929
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index af2c411ed18..bfda9569514 100644
--- a/build.gradle
+++ b/build.gradle
@@ -158,6 +158,11 @@ check.dependsOn rat
// for the test definitions.
task javaPreCommit() {
dependsOn ":rat"
+ // We need to list the model/* builds since sdks/java/core doesn't
+ // depend on any of the model.
+ dependsOn ":beam-model-pipeline:build"
+ dependsOn ":beam-model-job-management:build"
+ dependsOn ":beam-model-fn-execution:build"
dependsOn ":beam-sdks-java-core:buildNeeded"
dependsOn ":beam-sdks-java-core:buildDependents"
dependsOn ":beam-examples-java:preCommit"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 121960)
Time Spent: 40m (was: 0.5h)
> Task
> :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses
> broken
> ---
>
> Key: BEAM-4764
> URL: https://issues.apache.org/jira/browse/BEAM-4764
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Henning Rohde
>Assignee: Luke Cwik
>Priority: Blocker
> Fix For: Not applicable
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Running from head with no changes:
> $ ./gradlew build
> [...]
> > Task :beam-sdks-java-harness:compileJava
> Note:
> /Users/herohde/go/src/github.com/apache/beam/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java
> uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> > Task
> > :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses
> > FAILED
> > Task :beam-sdks-go:resolveBuildDependencies
> Resolving google.golang.org/api:
> commit='386d4e5f4f92f86e6aec85985761bba4b938a2d5',
> urls=[https://code.googlesource.com/google-api-go-client]
> > Task :beam-sdks-go:resolveBuildDependencies
> Resolving google.golang.org/genproto:
> commit='2b5a72b8730b0b16380010cfe5286c42108d88e7',
> urls=[https://github.com/google/go-genproto]
> Resolving google.golang.org/grpc:
> commit='7646b5360d049a7ca31e9133315db43456f39e2e',
> urls=[https://github.com/grpc/grpc-go]
> Resolving cached github.com/coreos/etcd:
> commit='11214aa33bf5a47d3d9d8dafe0f6b97237dfe921',
> urls=[https://github.com/coreos/etcd.git, g...@github.com:coreos/etcd.git]
> Resolving cached github.com/coreos/etcd:
> commit='11214aa33bf5a47d3d9d8dafe0f6b97237dfe921',
> urls=[https://github.com/coreos/etcd.git, g...@github.com:coreos/etcd.git]
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task
> ':beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses'.
> > Could not find method zipTree() for arguments
> > [/Users/herohde/go/src/github.com/apache/beam/model/fn-execution/build/libs/beam-model-fn-execution-2.6.0-SNAPSHOT-shaded.jar]
> > on task
> > ':beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses'
> > of type org.gradle.api.DefaultTask.
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> Deprecated Gradle features were used in this build, making it incompatible
> with Gradle 5.0.
> See
> https://docs.gradle.org/4.8/userguide/command_line_interface.html#sec:command_line_warnings
> BUILD FAILED in 4m 7s
> 119 actionable tasks: 88 executed, 6 from cache, 25 up-to-date
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-4764) Task :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses broken
[ https://issues.apache.org/jira/browse/BEAM-4764?focusedWorklogId=121931&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121931 ] ASF GitHub Bot logged work on BEAM-4764: Author: ASF GitHub Bot Created on: 11/Jul/18 15:56 Start Date: 11/Jul/18 15:56 Worklog Time Spent: 10m Work Description: lukecwik opened a new pull request #5929: [BEAM-4764] Fix java precommit to ensure that any checks in model/* are run. URL: https://github.com/apache/beam/pull/5929 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 121931) Time Spent: 0.5h (was: 20m) > Task > :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses > broken > --- > > Key: BEAM-4764 > URL: https://issues.apache.org/jira/browse/BEAM-4764 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Henning Rohde >Assignee: Luke Cwik >Priority: Blocker > Fix For: Not applicable > > Time Spent: 0.5h > Remaining Estimate: 0h > > Ru
[jira] [Work logged] (BEAM-4764) Task :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses broken
[
https://issues.apache.org/jira/browse/BEAM-4764?focusedWorklogId=121928&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121928
]
ASF GitHub Bot logged work on BEAM-4764:
Author: ASF GitHub Bot
Created on: 11/Jul/18 15:42
Start Date: 11/Jul/18 15:42
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5928: [BEAM-4764] Fix
missing reference to project to be able to refer to the zipTree method.
URL: https://github.com/apache/beam/pull/5928
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 49147654ba9..80e94f3a7dd 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -1329,7 +1329,7 @@ artifactId=${project.name}
inputs.files project.configurations.shadowTest.artifacts.files
doLast {
(project.configurations.shadow.artifacts.files +
project.configurations.shadowTest.artifacts.files).each {
-FileTree exposedClasses = zipTree(it).matching {
+FileTree exposedClasses = project.zipTree(it).matching {
include "**/*.class"
exclude "org/apache/beam/**"
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 121928)
Time Spent: 20m (was: 10m)
> Task
> :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses
> broken
> ---
>
> Key: BEAM-4764
> URL: https://issues.apache.org/jira/browse/BEAM-4764
> Project: Beam
> Issue Type: Bug
> Components: build-system
>Reporter: Henning Rohde
>Assignee: Luke Cwik
>Priority: Blocker
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Running from head with no changes:
> $ ./gradlew build
> [...]
> > Task :beam-sdks-java-harness:compileJava
> Note:
> /Users/herohde/go/src/github.com/apache/beam/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java
> uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> > Task
> > :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses
> > FAILED
> > Task :beam-sdks-go:resolveBuildDependencies
> Resolving google.golang.org/api:
> commit='386d4e5f4f92f86e6aec85985761bba4b938a2d5',
> urls=[https://code.googlesource.com/google-api-go-client]
> > Task :beam-sdks-go:resolveBuildDependencies
> Resolving google.golang.org/genproto:
> commit='2b5a72b8730b0b16380010cfe5286c42108d88e7',
> urls=[https://github.com/google/go-genproto]
> Resolving google.golang.org/grpc:
> commit='7646b5360d049a7ca31e9133315db43456f39e2e',
> urls=[https://github.com/grpc/grpc-go]
> Resolving cached github.com/coreos/etcd:
> commit='11214aa33bf5a47d3d9d8dafe0f6b97237dfe921',
> urls=[https://github.com/coreos/etcd.git, g...@github.com:coreos/etcd.git]
> Resolving cached github.com/coreos/etcd:
> commit='11214aa33bf5a47d3d9d8dafe0f6b97237dfe921',
> urls=[https://github.com/coreos/etcd.git, g...@github.com:coreos/etcd.git]
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task
> ':beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses'.
> > Could not find method zipTree() for arguments
> > [/Users/herohde/go/src/github.com/apache/beam/model/fn-execution/build/libs/beam-model-fn-execution-2.6.0-SNAPSHOT-shaded.jar]
> > on task
> > ':beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses'
> > of type org.gradle.api.DefaultTask.
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or
> --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> Deprecated Gradle features were used in this build, making it incompatible
> with Gradle 5.0.
> See
> https://docs.gradle.org/4.8/userguide/command_line_interface.html#sec:comm
[jira] [Work logged] (BEAM-4764) Task :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses broken
[ https://issues.apache.org/jira/browse/BEAM-4764?focusedWorklogId=121926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121926 ] ASF GitHub Bot logged work on BEAM-4764: Author: ASF GitHub Bot Created on: 11/Jul/18 15:41 Start Date: 11/Jul/18 15:41 Worklog Time Spent: 10m Work Description: lukecwik opened a new pull request #5928: [BEAM-4764] Fix missing reference to project to be able to refer to the zipTree method. URL: https://github.com/apache/beam/pull/5928 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 121926) Time Spent: 10m Remaining Estimate: 0h > Task > :beam-model-fn-execution:validateShadedJarDoesntLeakNonOrgApacheBeamClasses > broken > --- > > Key: BEAM-4764 > URL: https://issues.apache.org/jira/browse/BEAM-4764 > Project: Beam > Issue Type: Bug > Components: build-system >Reporter: Henning Rohde >Assignee: Luke Cwik >Priority: Blocker > Time Spent: 10m > Remaining Estimate: 0h > > Ru
