Reduce the visibility of TransformHierarchy Node Mutators These mutators should not be accessible when visiting the nodes.
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/7c5c7910 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/7c5c7910 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/7c5c7910 Branch: refs/heads/master Commit: 7c5c7910c0b8cba8623a1c49fc24c51ea691dac3 Parents: 569e8d7 Author: Thomas Groh <tg...@google.com> Authored: Thu Dec 1 13:22:11 2016 -0800 Committer: Thomas Groh <tg...@google.com> Committed: Thu Dec 1 14:34:21 2016 -0800 ---------------------------------------------------------------------- .../java/org/apache/beam/sdk/runners/TransformHierarchy.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/7c5c7910/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java index 662acc1..e9829cc 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java @@ -263,7 +263,7 @@ public class TransformHierarchy { /** * Adds an output to the transform node. */ - public void setOutput(POutput output) { + private void setOutput(POutput output) { checkState(!finishedSpecifying); checkState( this.output == null, "Tried to specify more than one output for %s", getFullName()); @@ -304,13 +304,14 @@ public class TransformHierarchy { return AppliedPTransform.of( getFullName(), getInput(), getOutput(), (PTransform) getTransform()); } + /** * Visit the transform node. * * <p>Provides an ordered visit of the input values, the primitive transform (or child nodes for * composite transforms), then the output values. */ - public void visit(PipelineVisitor visitor, Set<PValue> visitedValues) { + private void visit(PipelineVisitor visitor, Set<PValue> visitedValues) { if (!finishedSpecifying) { finishSpecifying(); } @@ -352,7 +353,7 @@ public class TransformHierarchy { * * <p>All inputs are finished first, then the transform, then all outputs. */ - public void finishSpecifying() { + private void finishSpecifying() { if (finishedSpecifying) { return; }