[GitHub] incubator-beam pull request #1009: [BEAM-551] Add ValueProvider class (Take ...

2016-10-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1009


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-beam pull request #1009: [BEAM-551] Add ValueProvider class (Take ...

2016-09-26 Thread sammcveety
GitHub user sammcveety opened a pull request:

https://github.com/apache/incubator-beam/pull/1009

[BEAM-551] Add ValueProvider class (Take 2)

My branch had become a dumpster fire, so I'm opening a fresh PR (history is 
here: https://github.com/apache/incubator-beam/pull/827).

Add a basic implementation of StaticValueProvider and DynamicValueProvider.

@dhalperi , could you please take a look?  Hoping the jackson API surface 
test failures are easy to fix. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sammcveety/incubator-beam sgmc/vp2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1009.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1009


commit 3e55e508ede87b92f0d78bc960803bc546a8a354
Author: sammcveety 
Date:   2016-09-26T22:27:15Z

Reset of ValueProvider PR.

commit 562baf6ec7a9a77dad797c5a40df1f5122e5d1b8
Author: sammcveety 
Date:   2016-09-26T22:46:05Z

Fix checkstyle, etc., failures.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---