GitHub user mbuccini opened a pull request:
https://github.com/apache/incubator-beam/pull/1017
Beam 517 - Check versions of pip and cython
I have added a check so that the setup fails if pip <= 0.7.0 is not
installed.
In addition, I have added cython as an optional dependency, so that it's
installed only if the user decides to do so, e.g., via
`pip install -e .[cython]`
The Readme file has also been updated, although I think that it may need
some refactoring in the future, when/if the project is packaged and deployed on
pypi as apache-beam. In that case, it would be possible to execute something
like:
`pip install apache-beam[cython]`
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [X] Replace `` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.txt).
---
For more details about the issue, see the jira issue:
https://issues.apache.org/jira/browse/BEAM-517
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbuccini/incubator-beam beam-517
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1017.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1017
commit 588b4a35c6d20ade7965c187887c83515eef16c1
Author: mbuccini
Date: 2016-09-27T08:30:38Z
Fixed pip requirement and set cython as extra package.
commit 66caeb8c6276e2b349ed68f161e85dc910d515a9
Author: mbuccini
Date: 2016-09-27T08:50:16Z
fixed README for cython/pip versions
commit cb4efec4cc1c400b24e062b007374c0dd7b33aa6
Author: mbuccini
Date: 2016-09-27T08:54:56Z
Fixed anchors/titles
commit c168e69491d0c1df8aeed0574dee75e375dea27f
Author: mbuccini
Date: 2016-09-27T08:57:14Z
Fixed typo
commit 8adbd8f4ea18b0d91a5c55914fed31d5b3f70c12
Author: mbuccini
Date: 2016-09-27T09:34:05Z
Removed section about clone/install Apache Beam
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
