GitHub user amitsela opened a pull request: https://github.com/apache/incubator-beam/pull/1073
[BEAM-735] PAssertStreaming should make sure the assertion happened. Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/amitsela/incubator-beam BEAM-735 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1073.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1073 ---- commit ca3aa78d9651d8d8fc981234c9f4707414dc9738 Author: Sela <ans...@paypal.com> Date: 2016-10-09T18:38:14Z PAssertStreaming shuold check an assertion happened. commit 4adc3827443a6d8490f6b1799fce5c820c9484a5 Author: Sela <ans...@paypal.com> Date: 2016-10-09T18:39:00Z Test assert for skipped assertion.. commit 948fc9d0e894c06e555cf47fc3db48e6aad55008 Author: Sela <ans...@paypal.com> Date: 2016-10-09T18:39:53Z This name is more true to the natureof this test. commit 346e85df4436a07a8dd30d793d7fa0ca4bf23806 Author: Sela <ans...@paypal.com> Date: 2016-10-09T18:40:46Z Fix according to new PAssertStreaming. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---