[GitHub] incubator-beam pull request #1089: [BEAM-742] Replicate triggers to runners-...

[kennknowles]

Github user kennknowles closed the pull request at:

https://github.com/apache/incubator-beam/pull/1089


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1089: [BEAM-742] Replicate triggers to runners-...

[kennknowles]

GitHub user kennknowles opened a pull request:

https://github.com/apache/incubator-beam/pull/1089

[BEAM-742] Replicate triggers to runners-core, favoring commit history over 
blame

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [x] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

R: @bjchambers 

This is identical to #1083 but with the first and third commit squashed 
together. Based on my readings on the subject, I would have expected git to 
actually track the content, at least when using blame, but it does not seem to.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kennknowles/incubator-beam 
TriggerReactor-squashed

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1089.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1089


commit f63f81e2d8fad16d668809c8b291256ae5477ab1
Author: Kenneth Knowles 
Date:   2016-06-24T03:05:27Z

Copy triggers to runners-core

This commit is effectively a "git hint" that all the files
in runners-core are moved from prior files. The moved files
will be replaced.

commit f0913147af072cda06a2da4ef6933e311b94dd90
Author: Kenneth Knowles 
Date:   2016-06-24T03:31:10Z

Rename trigger reactors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---