[jira] [Commented] (BEAM-361) Batch Pub/Sub sink does not set idLabel

2016-10-17 Thread Kenneth Knowles (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582752#comment-15582752
 ] 

Kenneth Knowles commented on BEAM-361:
--

Hi [~venbijjam]. I'll assign this to you. Have you read [the contribution 
guide|http://beam.apache.org/contribute/contribution-guide/]? 
[~dhalp...@google.com] or [~mil...@google.com]] may have some feedback on your 
approach, and then you would code it up and produce a PR with a title starting 
with {{\[BEAM-361\]}}.

> Batch Pub/Sub sink does not set idLabel
> ---
>
> Key: BEAM-361
> URL: https://issues.apache.org/jira/browse/BEAM-361
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Daniel Mills
>  Labels: newbie, starter
>
> The transform should generate a unique token (must be stable across retries), 
> and set it on outgoing pubsub messages if an idLabel has been set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-361) Batch Pub/Sub sink does not set idLabel

2016-10-13 Thread Ven Bijjam (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573234#comment-15573234
 ] 

Ven Bijjam commented on BEAM-361:
-

I am thinking along these lines:: in
{code}PubsubUnboundedSource{code} 
{code}..\sdks\java\core\src\main\java\org\apache\beam\sdk\io\PubsubUnboundedSource.java{code}

change the following line {code}this.idLabel = idLabel; {code} 
to the following:
{code}this.idLabel = idLabel == null ? 
UUID.nameUUIDFromBytes(timestampLabel.getBytes()).toString() : idLabel;{code}

> Batch Pub/Sub sink does not set idLabel
> ---
>
> Key: BEAM-361
> URL: https://issues.apache.org/jira/browse/BEAM-361
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Daniel Mills
>  Labels: newbie, starter
>
> The transform should generate a unique token (must be stable across retries), 
> and set it on outgoing pubsub messages if an idLabel has been set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-361) Batch Pub/Sub sink does not set idLabel

2016-10-13 Thread Ven Bijjam (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573125#comment-15573125
 ] 

Ven Bijjam commented on BEAM-361:
-

Hi
I would like to take this up. But I am not sure how to contribute as this is my 
first time getting involved in open source project.

> Batch Pub/Sub sink does not set idLabel
> ---
>
> Key: BEAM-361
> URL: https://issues.apache.org/jira/browse/BEAM-361
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Daniel Mills
>  Labels: newbie, starter
>
> The transform should generate a unique token (must be stable across retries), 
> and set it on outgoing pubsub messages if an idLabel has been set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-361) Batch Pub/Sub sink does not set idLabel

2016-07-06 Thread Daniel Halperin (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15365649#comment-15365649
 ] 

Daniel Halperin commented on BEAM-361:
--

This probably requires copying some logic from PubsubUnboundedSource to 
PubsubReader.

Alternately, maybe PubsubReader should be deleted and PubsubUnboundedSource 
used instead using {{BoundedReadFromUnboundedSource}}.

This is a reasonable starter task.

> Batch Pub/Sub sink does not set idLabel
> ---
>
> Key: BEAM-361
> URL: https://issues.apache.org/jira/browse/BEAM-361
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-java-gcp
>Reporter: Daniel Mills
>  Labels: newbie, starter
>
> The transform should generate a unique token (must be stable across retries), 
> and set it on outgoing pubsub messages if an idLabel has been set



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)