[jira] [Commented] (BEAM-597) Provide type information from Coders

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729854#comment-15729854
 ] 

ASF GitHub Bot commented on BEAM-597:
-

GitHub user jeremiele opened a pull request:

https://github.com/apache/incubator-beam/pull/1537

[BEAM-597] Added a new method on Coder which returns a TypeDescriptor.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

The new method allows returning type information about the data being
encoded and decoded by a Coder.
Added a default implementation to StandardCoder which returns the
TypeDescriptor for Object to ease the transition and avoid breaking
implementations relying on StandardCoder or AtomicCoder.

This will break classes implementing the Coder interface directly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeremiele/incubator-beam 
add_method_to_coder_for_typedescriptor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1537


commit 4a892401689fd01a831ff8904e46f917f8f1
Author: Jeremie Lenfant-Engelmann 
Date:   2016-12-07T19:29:29Z

Added a new method on Coder which returns a TypeDescriptor.

The new method allows returning type information about the data being
encoded and decoded by a Coder.
Added a default implementation to StandardCoder which returns the
TypeDescriptor for Object to ease the transition and avoid breaking
implementations relying on StandardCoder or AtomicCoder.

This will break classes implementing the Coder interface directly.




> Provide type information from Coders
> 
>
> Key: BEAM-597
> URL: https://issues.apache.org/jira/browse/BEAM-597
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Jeremie Lenfant-Engelmann
>Assignee: Jeremie Lenfant-Engelmann
>Priority: Minor
>
> The Coder interface should return a TypeDescriptor describing the type that 
> is currently encoded/decoded by the Coder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-597) Provide type information from Coders

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626865#comment-15626865
 ] 

ASF GitHub Bot commented on BEAM-597:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/968


> Provide type information from Coders
> 
>
> Key: BEAM-597
> URL: https://issues.apache.org/jira/browse/BEAM-597
> Project: Beam
>  Issue Type: Improvement
>  Components: sdk-java-core
>Reporter: Jeremie Lenfant-Engelmann
>Assignee: Jeremie Lenfant-Engelmann
>Priority: Minor
>
> The Coder interface should return a TypeDescriptor describing the type that 
> is currently encoded/decoded by the Coder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-597) Provide type information from Coders

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497901#comment-15497901
 ] 

ASF GitHub Bot commented on BEAM-597:
-

GitHub user jeremiele opened a pull request:

https://github.com/apache/incubator-beam/pull/968

[BEAM-597] Added public where method to specify parameter types.

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jeremiele/incubator-beam 
add_where_to_type_descriptor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #968


commit 9ab876f2a2d37ac0142103e1f3509a9bac900ad1
Author: Jeremie Lenfant-Engelmann 
Date:   2016-08-17T22:52:50Z

Added a where method on TypeDescriptor to allow substituting a type 
parameter
with a TypeDescriptor. In the process introduced a TypeParameter class which
represents the parameter type.
This is useful when having a type such as Set to be able to specify
what T is as part of the TypeDescriptor information.

commit 6dd324ec418b1f9e8bc7c01ce4654b3309bedb30
Author: Aljoscha Krettek 
Date:   2016-06-11T08:55:55Z

Fix Emission in startBundle/finishBundle in Flink Wrappers

commit 42e9649e588cd1ad5cb004d61daca785beb39552
Author: Aljoscha Krettek 
Date:   2016-06-11T09:42:12Z

[BEAM-253] Unify Flink-Streaming Operator Wrappers

This also replaces the custom Flink StateInternals by proper Flink
Partitioned StateInternals.

commit eaba203c5fa283923150c692321350bd37aefa56
Author: Aljoscha Krettek 
Date:   2016-07-10T15:01:38Z

Fix Checkstyle Errors in FlinkStreamingTransformTranslators

commit f3f52b0500f59054c6b701bcd9b0a35e30e6d524
Author: Aljoscha Krettek 
Date:   2016-07-11T12:08:35Z

[BEAM-102] Add Side Inputs in Flink Streaming Runner

This adds a generic SideInputHandler in runners-core that is only used
by the Flink runner right now but can be used by other runner
implementations.

commit 4c6e3a3b761d76e9a1b51be36ab47520ac93de9b
Author: Aljoscha Krettek 
Date:   2016-07-23T08:48:42Z

Allow DoFn Reuse in ParDoTest.TestDoFnWithContext

commit 1cfbaeec29b468a46f9b07ba6c7168fdd177352a
Author: Aljoscha Krettek 
Date:   2016-07-24T10:04:28Z

Don't Suppress Throwable in PAssert in Streaming Mode

commit c36e9bd8eb3d3a305d995b9982b872f356cf9618
Author: Aljoscha Krettek 
Date:   2016-07-26T12:02:00Z

Enable Flink Streaming Runner RunnableOnService tests

commit 17ee0a21e8751b6f8dc15966347db3a99ae5de72
Author: Thomas Groh 
Date:   2016-07-27T16:04:06Z

Fix combine tests with Accumulation Mode

These tests were not written in such a way as to succeed if the trigger
fired multiple times.

commit d9dc86e84bf096804c88381722069c21c734a78e
Author: Kenneth Knowles 
Date:   2016-07-27T21:23:15Z

Replace ParDo with simpler transforms where possible

There are a number of places in the Java SDK where we use
ParDo.of(DoFn) when MapElements or other higher-level
composites are applicable and readable. This change
alters a number of those.

commit 00f0ff732217ae0411be75e3cadd6ca2107c50de
Author: Thomas Groh 
Date:   2016-07-28T15:26:43Z

Use AllPanes as the PaneExtractor in IterableAssert

This ensures that tests with triggering in the global window which assert
on the entire PCollection (not a singleton iterable) will succeed over the
entire PCollection

commit 491d1cb8b5de558e31184cf8c602a2065367ff06
Author: Thomas Groh 
Date:   2016-08-11T22:46:10Z

Add inEarlyPanesInGlobalWindow as a PAssert Extractor

This is for use in asserting the contents of speculative panes in the
global window.

commit bbdb1f04adfd3504c7544bb6e878cebfbf9ac362
Author: Dan Halperin 
Date:   2016-08-15T06:08:21Z

FileBasedSink: