[jira] [Commented] (BEAM-763) BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid RunnableOnService test

2016-10-17 Thread Pei He (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583650#comment-15583650
 ] 

Pei He commented on BEAM-763:
-

i don't have permission to resolve this issue. Could someone help me to mark it 
as fixed?

> BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid 
> RunnableOnService test
> --
>
> Key: BEAM-763
> URL: https://issues.apache.org/jira/browse/BEAM-763
> Project: Beam
>  Issue Type: Test
>Reporter: Luke Cwik
>Assignee: Pei He
>Priority: Minor
>
> TestPipeline.create(options) is not compatible with how TestPipeline 
> functions. This overrides the properties provided by the maven 
> surefire/failsafe profiles setup by the various runners for integration 
> testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-763) BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid RunnableOnService test

2016-10-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583643#comment-15583643
 ] 

ASF GitHub Bot commented on BEAM-763:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/1119


> BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid 
> RunnableOnService test
> --
>
> Key: BEAM-763
> URL: https://issues.apache.org/jira/browse/BEAM-763
> Project: Beam
>  Issue Type: Test
>Reporter: Luke Cwik
>Assignee: Pei He
>Priority: Minor
>
> TestPipeline.create(options) is not compatible with how TestPipeline 
> functions. This overrides the properties provided by the maven 
> surefire/failsafe profiles setup by the various runners for integration 
> testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-763) BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid RunnableOnService test

2016-10-17 Thread Pei He (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583339#comment-15583339
 ] 

Pei He commented on BEAM-763:
-

BigQueryIOTest doesn't work with RunnableOnService:
https://issues.apache.org/jira/browse/BEAM-436

However, we didn't change it to NeedsRunner when backport PR from Dataflow.

Sent PR to update.

> BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid 
> RunnableOnService test
> --
>
> Key: BEAM-763
> URL: https://issues.apache.org/jira/browse/BEAM-763
> Project: Beam
>  Issue Type: Test
>Reporter: Luke Cwik
>Assignee: Pei He
>Priority: Minor
>
> TestPipeline.create(options) is not compatible with how TestPipeline 
> functions. This overrides the properties provided by the maven 
> surefire/failsafe profiles setup by the various runners for integration 
> testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BEAM-763) BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid RunnableOnService test

2016-10-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BEAM-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583315#comment-15583315
 ] 

ASF GitHub Bot commented on BEAM-763:
-

GitHub user peihe opened a pull request:

https://github.com/apache/incubator-beam/pull/1119

[BEAM-763] Update BigQueryIOTest.testBuildSourceWithTableAndSqlDialect to 
NeedsRunner tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/peihe/incubator-beam 
change-bq-tests-to-needsRunners

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1119


commit 3965dbdb184075333086a87448b2f153e66654e2
Author: Pei He 
Date:   2016-10-17T20:13:52Z

[BEAM-763] Update BigQueryIOTest.testBuildSourceWithTableAndSqlDialect to 
NeedsRunner tests.




> BigQueryIOTest.testBuildSourceWithTableAndSqlDialect is not a valid 
> RunnableOnService test
> --
>
> Key: BEAM-763
> URL: https://issues.apache.org/jira/browse/BEAM-763
> Project: Beam
>  Issue Type: Test
>Reporter: Luke Cwik
>Assignee: Pei He
>Priority: Minor
>
> TestPipeline.create(options) is not compatible with how TestPipeline 
> functions. This overrides the properties provided by the maven 
> surefire/failsafe profiles setup by the various runners for integration 
> testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)