This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch branch-4.6
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/branch-4.6 by this push:
new e248147 Fixed Journal stats names
e248147 is described below
commit e248147463281986d29d75d959732834f4225a9b
Author: Matteo Merli <mme...@apache.org>
AuthorDate: Tue Mar 13 16:49:50 2018 -0700
Fixed Journal stats names
In `BOOKKEEPER-1009: Use multiple journals in bookie`
123eccd435a4a96a9147ed4a24efbe9025fe79ba there was a change in the metrics name
that would be affecting also user not running with multiple journal.
It is a bit inconvenient to aggregate the stats in the metrics collector
(how to aggregate 99pct latency for example).
I think the best option is to have a single metric even when using multiple
journal threads.
Author: Matteo Merli <mme...@apache.org>
Reviewers: Ivan Kelly <iv...@apache.org>, Enrico Olivelli
<eolive...@gmail.com>, Sijie Guo <si...@apache.org>
This closes #1250 from merlimat/journal-metric-names
(cherry picked from commit 4578e6d65a304c870fcba013099badd6018c95de)
Signed-off-by: Sijie Guo <si...@apache.org>
---
.../src/main/java/org/apache/bookkeeper/bookie/Bookie.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
index 074c29c..711b2b8 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
@@ -695,7 +695,7 @@ public class Bookie extends BookieCriticalThread {
journals = Lists.newArrayList();
for (int i = 0; i < journalDirectories.size(); i++) {
journals.add(new Journal(journalDirectories.get(i),
- conf, ledgerDirsManager,
statsLogger.scope(JOURNAL_SCOPE + "_" + i)));
+ conf, ledgerDirsManager,
statsLogger.scope(JOURNAL_SCOPE)));
}
CheckpointSource checkpointSource = new CheckpointSourceList(journals);
--
To stop receiving notification emails like this one, please contact
si...@apache.org.
