[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714783 ## File path: dsn_test.go ## @@ -213,80 +156,3 @@ func TestValidTransactionIsolation(t *testing.T)

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714842 ## File path: http_client_wrappers.go ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714769 ## File path: dsn_test.go ## @@ -213,80 +156,3 @@ func TestValidTransactionIsolation(t *testing.T)

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714811 ## File path: http_client_wrappers.go ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714795 ## File path: http_client_wrappers.go ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714862 ## File path: driver.go ## @@ -47,26 +48,28 @@ import ( // Driver is exported to allow it to be

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714831 ## File path: http_client_wrappers.go ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite-avatica-go] trusch commented on issue #43: [CALCITE-3248] add Connector implementation

trusch commented on issue #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521117298 With regards to the documentation change: Should I just remove the docs, or also the parsing in the dsn? For maximum backwards

[GitHub] [calcite-avatica-go] F21 commented on issue #43: [CALCITE-3248] add Connector implementation

F21 commented on issue #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521122453 @trusch The changes look great! In regards to the `username` and `password` parameters in the DSN, we should just remove them. They were

[GitHub] [calcite-avatica-go] trusch commented on issue #43: [CALCITE-3248] add Connector implementation

trusch commented on issue #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521118464 I'm waiting with the rebase until you are ready with the review, that way you can more easily track changes.

[GitHub] [calcite] jinxing64 opened a new pull request #1377: [CALCITE-3249] Substitution#getRexShuttle does not consider RexLiteral

jinxing64 opened a new pull request #1377: [CALCITE-3249] Substitution#getRexShuttle does not consider RexLiteral URL: https://github.com/apache/calcite/pull/1377 Current `Substitution#getRexShuttle` does not take `RexLiteral` into consideration. Thus below query & mv fails matching:

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714731 ## File path: dsn_test.go ## @@ -62,18 +54,6 @@ func TestParseDSN(t *testing.T) { if

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714708 ## File path: dsn.go ## @@ -42,22 +42,6 @@ type Config struct { location

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714682 ## File path: driver.go ## @@ -47,26 +48,28 @@ import ( // Driver is exported to allow it to be

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714722 ## File path: dsn.go ## @@ -138,80 +110,6 @@ func ParseDSN(dsn string) (*Config, error) {

[GitHub] [calcite-avatica-go] trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation

trusch commented on a change in pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#discussion_r313714749 ## File path: dsn_test.go ## @@ -121,35 +93,6 @@ func TestDSNDefaults(t *testing.T) {

[GitHub] [calcite-avatica-go] F21 edited a comment on issue #43: [CALCITE-3248] add Connector implementation

F21 edited a comment on issue #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521122453 @trusch The changes look great! In regards to the `username` and `password` parameters in the DSN, we should just remove them.

[GitHub] [calcite-avatica-go] trusch commented on issue #43: [CALCITE-3248] add Connector implementation

trusch commented on issue #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521147664 @F21 everything should now be good! This is an automated message from

[GitHub] [calcite-avatica-go] F21 opened a new pull request #44: Use github actions for continuous integration

F21 opened a new pull request #44: Use github actions for continuous integration URL: https://github.com/apache/calcite-avatica-go/pull/44 This is an automated message from the Apache Git Service. To respond to the message,

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit d454174a4e596fc9f1a67876f637320ff3ecd6d6 Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (ddf8be5 -> d454174)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard ddf8be5 Try github actions new d454174 Try github actions This update added new

[GitHub] [calcite] psockali opened a new pull request #1378: [CALCITE-3219] introducing expandPredicate to dynamically control expression expansion

psockali opened a new pull request #1378: [CALCITE-3219] introducing expandPredicate to dynamically control expression expansion URL: https://github.com/apache/calcite/pull/1378 This is an automated message from the Apache

[calcite-avatica-go] branch github-actions updated (0644ad9 -> 5c696d0)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 0644ad9 Try github actions new 5c696d0 Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 5c696d0fc14d702741d9cbc84d51eecc6fa7b3ab Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 45e817a817265e95992553fc7837ac9e064d952a Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (5c696d0 -> 45e817a)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 5c696d0 Try github actions new 45e817a Try github actions This update added new

[calcite-avatica-go] branch github-actions updated (45e817a -> 89a6362)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 45e817a Try github actions new 89a6362 $Try github actions This update added new

[calcite-avatica-go] 01/01: $Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 89a63622bb7dd6b848c32948df21e0bf8c26810e Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit f9e302b52ea1b7c3d47326fc1e702b52c4043dea Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (89a6362 -> f9e302b)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 89a6362 $Try github actions new f9e302b Try github actions This update added new

[GitHub] [calcite-avatica-go] F21 closed pull request #44: Use github actions for continuous integration

F21 closed pull request #44: Use github actions for continuous integration URL: https://github.com/apache/calcite-avatica-go/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please

[calcite-avatica-go] branch github-actions created (now 3fdf9e2)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. at 3fdf9e2 Try github actions No new revisions were added by this update.

[calcite-avatica-go] branch github-actions updated (3fdf9e2 -> ddf8be5)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. omit 3fdf9e2 Try github actions new ddf8be5 Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit ddf8be52b637b4e17cd7c850e272c21b875ab425 Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (d454174 -> 0644ad9)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard d454174 Try github actions new 0644ad9 Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 0644ad9081202793231b3f572d89c3c32be4ac6d Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 8845f293ba8edd40f7555964e3af41f5c3f2a18f Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (f9e302b -> 8845f29)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard f9e302b Try github actions new 8845f29 Try github actions This update added new

[GitHub] [calcite] wangzzu commented on a change in pull request #1372: [CALCITE-3246] NullPointerException while deserializing udf operator.

wangzzu commented on a change in pull request #1372: [CALCITE-3246] NullPointerException while deserializing udf operator. URL: https://github.com/apache/calcite/pull/1372#discussion_r313849083 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java

[GitHub] [calcite] xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521489629 > @xy2953396112 I re-trigger the tests and they all passed. THX,is there any problem?

[GitHub] [calcite] chunweilei commented on issue #1372: [CALCITE-3246] NullPointerException while deserializing udf operator.

chunweilei commented on issue #1372: [CALCITE-3246] NullPointerException while deserializing udf operator. URL: https://github.com/apache/calcite/pull/1372#issuecomment-521489684 LGTM This is an automated message from the

[GitHub] [calcite] danny0405 commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

danny0405 commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314170399 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

danny0405 commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314170420 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite] danny0405 commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

danny0405 commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#issuecomment-521508961 Thanks @ihuzenko , i see there are so many code refactoring which is not relative with the fix in

[GitHub] [calcite] hsyuan commented on a change in pull request #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

hsyuan commented on a change in pull request #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#discussion_r314101148 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/tree/BinaryExpression.java

[calcite-avatica-go] branch github-actions updated (2d41420 -> 77a9375)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 2d41420 Try github actions new 77a9375 Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 77a937533ee25886a0715fe4a62a36c3e8ec24fe Author: Francis Chuang AuthorDate: Wed Aug 14

[GitHub] [calcite] hsyuan commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

hsyuan commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521461716 The tests failed, please check the style. This is an

[GitHub] [calcite] xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521462142 > I clicked `Approve` by mistake. Sorry about that. Ok,I have fixed the indent.Could you review again?

[GitHub] [calcite] danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521489169 @xy2953396112 I re-trigger the tests and they all passed.

[GitHub] [calcite] danny0405 commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift

danny0405 commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift URL: https://github.com/apache/calcite/pull/1380#discussion_r314158677 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

hsyuan commented on a change in pull request #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#discussion_r314102028 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/tree/BinaryExpression.java

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 2d41420d22b7b9acf8d2d6e5fbfd88b3d3e971d8 Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (fc64a9f -> 2d41420)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard fc64a9f Try github actions new 2d41420 Try github actions This update added new

[calcite] branch master updated: [CALCITE-3229] UnsupportedOperationException for UPDATE with IN query

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 7625938 [CALCITE-3229]

[GitHub] [calcite] chunweilei merged pull request #1358: [CALCITE-3229] UnsupportedOperationException for UPDATE with IN query

chunweilei merged pull request #1358: [CALCITE-3229] UnsupportedOperationException for UPDATE with IN query URL: https://github.com/apache/calcite/pull/1358 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] xy2953396112 removed a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 removed a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521470528 > The tests failed, please check the style. please help me review the test failed.

[GitHub] [calcite] xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521488024 > The tests failed, please check the style. Those tests have been passed，please review again.

[GitHub] [calcite] danny0405 commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…

danny0405 commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr… URL: https://github.com/apache/calcite/pull/1334#discussion_r314150683 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java

[GitHub] [calcite] xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521489629 > @xy2953396112 I re-trigger the tests and they all passed. THX,is there any problem? @danny0405

[calcite-avatica-go] branch github-actions updated (8845f29 -> 00f5a70)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 8845f29 Try github actions new 00f5a70 Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 00f5a70598a0c0d78433dd5e8998d11d04afae41 Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (432653c -> 1097f41)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 432653c Try github actions new 1097f41 Try github actions This update added new

[calcite-avatica-go] branch github-actions updated (22cc1fa -> a83e094)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 22cc1fa Try github actions discard 77a9375 Try github actions new a83e094 Try

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit a83e09408aeac7706b2a482d704e5d1c758eafb2 Author: Francis Chuang AuthorDate: Wed Aug 14

[GitHub] [calcite] chunweilei commented on issue #1372: [CALCITE-3246] NullPointerException while deserializing udf operator.

chunweilei commented on issue #1372: [CALCITE-3246] NullPointerException while deserializing udf operator. URL: https://github.com/apache/calcite/pull/1372#issuecomment-521484651 @yanlin-Lynn I would like to merge it if you could correct the commit message to` [CALCITE-3246]

[GitHub] [calcite] danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521509785 @xy2953396112 The changes looks good, thanks, This

[GitHub] [calcite] hsyuan commented on a change in pull request #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

hsyuan commented on a change in pull request #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#discussion_r314101983 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/tree/BinaryExpression.java

[calcite-avatica-go] branch github-actions updated (b2cf024 -> 432653c)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard b2cf024 Try github actions new 432653c Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit 432653cea4b49cb6a95a71ddebda81ef512a5fd8 Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit cac6354a86695f76565d7bb44f67f7d4e76e132f Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (1097f41 -> cac6354)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 1097f41 Try github actions new cac6354 Try github actions This update added new

[calcite-avatica-go] branch github-actions updated: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/github-actions by this push: new 22cc1fa Try

[GitHub] [calcite] danny0405 commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift

danny0405 commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift URL: https://github.com/apache/calcite/pull/1380#discussion_r314158337 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

danny0405 commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314170313 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit b2cf024daf440f073e19107fe6d8db6e202322e1 Author: Francis Chuang AuthorDate: Wed Aug 14

[calcite-avatica-go] branch github-actions updated (00f5a70 -> b2cf024)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard 00f5a70 Try github actions new b2cf024 Try github actions This update added new

[GitHub] [calcite] xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521488024 > The tests failed, please check the style. Those tests have been passed，please review again.

[GitHub] [calcite] xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521462142 > I clicked `Approve` by mistake. Sorry about that. Ok,I have fixed the indent.Could you review

[GitHub] [calcite] yanlin-Lynn commented on issue #1372: [CALCITE-3246] NullPointerException while deserializing udf operator.

yanlin-Lynn commented on issue #1372: [CALCITE-3246] NullPointerException while deserializing udf operator. URL: https://github.com/apache/calcite/pull/1372#issuecomment-521491281 > @yanlin-Lynn I would like to merge it if you could correct the commit message to` [CALCITE-3246]

[calcite-avatica-go] branch github-actions updated (cac6354 -> fc64a9f)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. discard cac6354 Try github actions new fc64a9f Try github actions This update added new

[calcite-avatica-go] 01/01: Try github actions

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch github-actions in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git commit fc64a9fd720319dcf25bd264e48f13f56342ef9b Author: Francis Chuang AuthorDate: Wed Aug 14

[GitHub] [calcite] xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521470528 > The tests failed, please check the style. please help me review the test failed.

[GitHub] [calcite] chunweilei commented on a change in pull request #1372: [CALCITE-3246] NullPointerException while deserializing udf operator.

chunweilei commented on a change in pull request #1372: [CALCITE-3246] NullPointerException while deserializing udf operator. URL: https://github.com/apache/calcite/pull/1372#discussion_r314150520 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java

[GitHub] [calcite] danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521519069 @xy2953396112 Thanks, let's fix them in one PR but with different commits.

[GitHub] [calcite] danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

danny0405 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521510854 @xy2953396112 Can we fix for all the exactly numeric types and fractional types ? - For integers: `BYTE` to

[GitHub] [calcite] jh3507 commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…

jh3507 commented on a change in pull request #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr… URL: https://github.com/apache/calcite/pull/1334#discussion_r314181502 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java

[GitHub] [calcite] xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 commented on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521516196 > @xy2953396112 Can we fix for all the exactly numeric types and fractional types ? > > * For integers:

[GitHub] [calcite] xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

xy2953396112 edited a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521516196 > @xy2953396112 Can we fix for all the exactly numeric types and fractional types ? > > * For

[GitHub] [calcite] danny0405 removed a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type.

danny0405 removed a comment on issue #1379: [CALCITE-3251]BinaryExpression evaluate method support Long type. URL: https://github.com/apache/calcite/pull/1379#issuecomment-521509785 @xy2953396112 The changes looks good, thanks,

[GitHub] [calcite] jinxing64 commented on issue #1370: [CALCITE-3239] Calc#accept(RexShuttle shuttle) does not update rowType

jinxing64 commented on issue #1370: [CALCITE-3239] Calc#accept(RexShuttle shuttle) does not update rowType URL: https://github.com/apache/calcite/pull/1370#issuecomment-521511162 @rubenada @danny0405 Thanks a lot for looking into this ~ If it makes sense to fix this issue in `Calc`,

[GitHub] [calcite] danny0405 merged pull request #1371: [CALCITE-3238] Support Time Zone suffix of DateTime types for SqlData…

danny0405 merged pull request #1371: [CALCITE-3238] Support Time Zone suffix of DateTime types for SqlData… URL: https://github.com/apache/calcite/pull/1371 This is an automated message from the Apache Git Service. To

[calcite] branch master updated: [CALCITE-3238] Support Time Zone suffix of DateTime types for SqlDataTypeSpec

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new f25734a [CALCITE-3238] Support Time Zone

[calcite-avatica-go] branch master updated: [CALCITE-3248] add Connector implementation. (Tino Rusch)

This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git The following commit(s) were added to refs/heads/master by this push: new 30a59fc [CALCITE-3248] add

[GitHub] [calcite-avatica-go] F21 commented on issue #43: [CALCITE-3248] add Connector implementation

F21 commented on issue #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521182564 Thanks @trusch! By the way, the Calcite and avatica community is active on the mailing list if you'd like to participate:

[GitHub] [calcite-avatica-go] F21 merged pull request #43: [CALCITE-3248] add Connector implementation

F21 merged pull request #43: [CALCITE-3248] add Connector implementation URL: https://github.com/apache/calcite-avatica-go/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] danny0405 commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

danny0405 commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r313799396 ## File path: core/src/main/java/org/apache/calcite/sql/SqlKind.java ## @@ -1279,6 +1279,46 @@

[GitHub] [calcite] zabetak commented on a change in pull request #1375: [CALCITE-3140][CALCITE-3141] Failures in slow tests & CI

zabetak commented on a change in pull request #1375: [CALCITE-3140][CALCITE-3141] Failures in slow tests & CI URL: https://github.com/apache/calcite/pull/1375#discussion_r313796132 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ##

[GitHub] [calcite] ihuzenko commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

ihuzenko commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#issuecomment-521185884 Hi @chunweilei , good catch. Updated commit and PR name.

[calcite] branch master updated: [CALCITE-3236] Handle issues found in static code analysis (DonnyZone)

This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 5c01713 [CALCITE-3236] Handle issues found

  1   2   >