[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314292811 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314292697 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite] danny0405 opened a new pull request #1382: [CALCITE-3250] Support nested collection type for SqlDataTypeSpec

2019-08-15 Thread GitBox
danny0405 opened a new pull request #1382: [CALCITE-3250] Support nested collection type for SqlDataTypeSpec URL: https://github.com/apache/calcite/pull/1382 Changes: * Add a new SqlTypeNameSpec SqlCollectionTypeNameSpec to describe nested collections type * Refactor

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314295965 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite-avatica-go] trusch opened a new pull request #45: harden error parsing.

2019-08-15 Thread GitBox
trusch opened a new pull request #45: harden error parsing. URL: https://github.com/apache/calcite-avatica-go/pull/45 This adds a nil check in the error parsing of the connection code. The old code assumes that the server always sends metadata in the ErrorResponse message. Because this is

[GitHub] [calcite] ihuzenko commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#issuecomment-521629928 @vvysotskyi , @danny0405 please take another look at the PR. I made 3 different commits, with changes, refactoring and

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r314282181 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
danny0405 commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r314282354 ## File path:

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314292978 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelStructuredTypeFlattener.java

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314292947 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelStructuredTypeFlattener.java

[calcite] branch master updated (7625938 -> 705be27)

2019-08-15 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 7625938 [CALCITE-3229] UnsupportedOperationException for UPDATE with IN query add 705be27 [CALCITE-3250]

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314293050 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelStructuredTypeFlattener.java

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314292853 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite] danny0405 merged pull request #1382: [CALCITE-3250] Support nested collection type for SqlDataTypeSpec

2019-08-15 Thread GitBox
danny0405 merged pull request #1382: [CALCITE-3250] Support nested collection type for SqlDataTypeSpec URL: https://github.com/apache/calcite/pull/1382 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] vvysotskyi commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
vvysotskyi commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314231023 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java ##

[GitHub] [calcite] ihuzenko commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on issue #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#issuecomment-521571501 Hi @danny0405 , thanks for participation in review. I divided refactoring and changes into 2 commits, and I'll prepare

[GitHub] [calcite] DonnyZone opened a new pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
DonnyZone opened a new pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381 This PR is proposed to handle the exception caused by Java `BigDecimal` type in

[GitHub] [calcite] ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported

2019-08-15 Thread GitBox
ihuzenko commented on a change in pull request #1374: [CALCITE-3138] Restructuring ROW type fields is not supported URL: https://github.com/apache/calcite/pull/1374#discussion_r314242038 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelStructuredTypeFlattener.java

[GitHub] [calcite-avatica-go] F21 closed pull request #45: harden error parsing.

2019-08-15 Thread GitBox
F21 closed pull request #45: harden error parsing. URL: https://github.com/apache/calcite-avatica-go/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite-avatica-go] F21 commented on issue #45: harden error parsing.

2019-08-15 Thread GitBox
F21 commented on issue #45: harden error parsing. URL: https://github.com/apache/calcite-avatica-go/pull/45#issuecomment-521824669 Thanks @trusch ! I've pulled your changes into master and updated commit message: 45474144b9d4cbbd9f8327385e8d6c1568b499f5

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r314543920 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -2952,7 +2952,7 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r314533796 ## File path: core/src/main/java/org/apache/calcite/config/CalciteConnectionProperty.java ## @@ -151,7

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r314537375 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java ## @@ -247,7 +248,22 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r314535680 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java ## @@ -247,7 +248,22 @@

[calcite-avatica-go] branch master updated (30a59fc -> 4547414)

2019-08-15 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git. from 30a59fc [CALCITE-3248] add Connector implementation. (Tino Rusch) add 4547414

[GitHub] [calcite] jh3507 commented on issue #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…

2019-08-15 Thread GitBox
jh3507 commented on issue #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr… URL: https://github.com/apache/calcite/pull/1334#issuecomment-521834473 I agree that Javadoc on each decorrelateRel function doesn't give much information(I guess this would be also

[GitHub] [calcite] lameyer commented on issue #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift

2019-08-15 Thread GitBox
lameyer commented on issue #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift URL: https://github.com/apache/calcite/pull/1380#issuecomment-521827599 @julianhyde this should be ready to review whenever

[GitHub] [calcite] hsyuan commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314532149 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #706: [CALCITE-2302] Implicit type cast support URL: https://github.com/apache/calcite/pull/706#discussion_r314546071 ## File path: core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java ## @@

[GitHub] [calcite] lameyer commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift

2019-08-15 Thread GitBox
lameyer commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift URL: https://github.com/apache/calcite/pull/1380#discussion_r314454735 ## File path:

[GitHub] [calcite] lameyer commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift

2019-08-15 Thread GitBox
lameyer commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift URL: https://github.com/apache/calcite/pull/1380#discussion_r314455871 ## File path:

[GitHub] [calcite] julianhyde commented on issue #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr…

2019-08-15 Thread GitBox
julianhyde commented on issue #1334: [CALCITE-3111] Allow custom implementations of Correlate in RelDecorr… URL: https://github.com/apache/calcite/pull/1334#issuecomment-521755452 I'm "meh" on the javadoc for all the `decorrelateRel` methods. The methods are called via reflective dispatch

[GitHub] [calcite] julianhyde commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift

2019-08-15 Thread GitBox
julianhyde commented on a change in pull request #1380: [CALCITE-3252] Syntax error while parsing CONVERT_TIMEZONE, TO_DATE, TO_TIMESTAMP functions on Redshift URL: https://github.com/apache/calcite/pull/1380#discussion_r314472192 ## File path:

[GitHub] [calcite] DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r314564881 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314569873 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314573112 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314561490 ## File path: core/src/test/java/org/apache/calcite/test/TableFunctionTest.java ## @@ -408,6 +408,23 @@ private

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314565352 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6 +4197,113

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314568528 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java ## @@ -1069,6 +1069,20 @@ private void

[GitHub] [calcite] jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314568523 ## File path:

[calcite] branch master updated: [CALCITE-3246] NullPointerException while deserializing udf operator (Wang Yanlin).

2019-08-15 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new f99ff5f [CALCITE-3246] NullPointerException

[GitHub] [calcite] chunweilei merged pull request #1372: [CALCITE-3246] NullPointerException while deserializing udf operator.

2019-08-15 Thread GitBox
chunweilei merged pull request #1372: [CALCITE-3246] NullPointerException while deserializing udf operator. URL: https://github.com/apache/calcite/pull/1372 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r314565681 ## File path:

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314567970 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3948,6 +3950,30 @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314567792 ## File path: core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java ## @@ -1058,6 +1058,57

[GitHub] [calcite] jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314568523 ## File path:

[GitHub] [calcite] DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r314571351 ## File path:

[GitHub] [calcite] DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-15 Thread GitBox
DonnyZone commented on a change in pull request #1381: [CALCITE-3245] CompileException in Janino when a query contains a division between a Double and a BigDecimal URL: https://github.com/apache/calcite/pull/1381#discussion_r314571351 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314569873 ## File path:

[GitHub] [calcite] jinxing64 commented on issue #1377: [CALCITE-3249] Substitution#getRexShuttle does not consider RexLiteral

2019-08-15 Thread GitBox
jinxing64 commented on issue #1377: [CALCITE-3249] Substitution#getRexShuttle does not consider RexLiteral URL: https://github.com/apache/calcite/pull/1377#issuecomment-521872457 @hsyuan Thanks for approve ! This is an

[GitHub] [calcite] jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#issuecomment-521874308 Thanks @hsyuan for review this ~ I refined by your comments and squashed the comments :)

[GitHub] [calcite] jinxing64 edited a comment on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 edited a comment on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#issuecomment-521874308 Thanks @hsyuan for review this ~ I refined by your comments and squashed the commits :)

[GitHub] [calcite] jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#issuecomment-521875383 Thanks for approve ~ This is an automated message

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314558640 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -285,6 +290,9 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314558280 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java ## @@ -1069,6 +1069,20 @@ private void

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314558858 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -469,6 +477,8 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314559820 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3948,6 +3950,30 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314559609 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6 +4197,113

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314559370 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6 +4197,113

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314558157 ## File path: core/src/main/java/org/apache/calcite/sql/SqlUtil.java ## @@ -1069,6 +1069,20 @@ private void

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314560079 ## File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java ## @@ -11135,6 +11135,35 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314562958 ## File path: core/src/main/java/org/apache/calcite/sql/SqlAsOperator.java ## @@ -102,12 +103,26 @@ public void

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314561921 ## File path: core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java ## @@ -1058,6 +1058,57 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314562365 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -888,6 +888,18 @@

[GitHub] [calcite] chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
chunweilei commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314564114 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -4175,6 +4197,113

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314567857 ## File path: core/src/test/java/org/apache/calcite/test/TableFunctionTest.java ## @@ -408,6 +408,23 @@

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314568396 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -469,6 +477,8

[GitHub] [calcite] pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive

2019-08-15 Thread GitBox
pengzhiwei2018 commented on a change in pull request #1138: [CALCITE-1581] UDTF like in hive URL: https://github.com/apache/calcite/pull/1138#discussion_r314568459 ## File path: core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java ## @@ -285,6 +290,9

[GitHub] [calcite] jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.

2019-08-15 Thread GitBox
jinxing64 commented on a change in pull request #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#discussion_r314568523 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql and planner hints

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql and planner hints URL: https://github.com/apache/calcite/pull/1354#discussion_r311817703 ## File path: core/src/main/java/org/apache/calcite/rel/hint/HintStrategy.java ## @@ -0,0 +1,74 @@ +/*

[GitHub] [calcite] hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql and planner hints

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql and planner hints URL: https://github.com/apache/calcite/pull/1354#discussion_r311818673 ## File path: core/src/main/java/org/apache/calcite/rel/hint/HintStrategy.java ## @@ -0,0 +1,74 @@ +/*

[GitHub] [calcite] hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql and planner hints

2019-08-15 Thread GitBox
hsyuan commented on a change in pull request #1354: [CALCITE-482] Implement sql and planner hints URL: https://github.com/apache/calcite/pull/1354#discussion_r311816950 ## File path: core/src/main/java/org/apache/calcite/rel/hint/HintStrategy.java ## @@ -0,0 +1,74 @@ +/*