[GitHub] [calcite] jinxing64 opened a new pull request #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical t…

2020-01-13 Thread GitBox
jinxing64 opened a new pull request #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical t… URL: https://github.com/apache/calcite/pull/1753 …o join condition (Jin Xing) https://issues.apache.org/jira/browse/CALCITE-3727 We need to check if `aboveFilters`

[GitHub] [calcite] jinxing64 commented on issue #1751: [CALCITE-3725] RelMetadataTest fails with NPE due to unsafe RelMetada…

2020-01-13 Thread GitBox
jinxing64 commented on issue #1751: [CALCITE-3725] RelMetadataTest fails with NPE due to unsafe RelMetada… URL: https://github.com/apache/calcite/pull/1751#issuecomment-573551498 Thanks a lot ~ This is an automated message

[calcite] branch master updated (5fc2fda -> dfd8da6)

2020-01-13 Thread vladimirsitnikov
This is an automated email from the ASF dual-hosted git repository. vladimirsitnikov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 5fc2fda [CALCITE-3725] RelMetadataTest fails with NPE due to unsafe RelMetadataQuery.instance call (Jin

[GitHub] [calcite] jinxing64 edited a comment on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing)

2020-01-13 Thread GitBox
jinxing64 edited a comment on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing) URL: https://github.com/apache/calcite/pull/1753#issuecomment-573622755 @34venu Yes, you can refer to org.apache.calcite.test.TableFunctionTest ~

[GitHub] [calcite] jinxing64 commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing)

2020-01-13 Thread GitBox
jinxing64 commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing) URL: https://github.com/apache/calcite/pull/1753#issuecomment-573622755 @34venu Yes, you can refer to org.apache.calcite.test.TableFunctionTest ~ If

[GitHub] [calcite] vlsi merged pull request #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing)

2020-01-13 Thread GitBox
vlsi merged pull request #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing) URL: https://github.com/apache/calcite/pull/1753 This is an automated message from the Apache

[GitHub] [calcite] jinxing64 commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing)

2020-01-13 Thread GitBox
jinxing64 commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing) URL: https://github.com/apache/calcite/pull/1753#issuecomment-573621038 Thanks a lot, @vlsi ~

[GitHub] [calcite] 34venu commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical t…

2020-01-13 Thread GitBox
34venu commented on issue #1753: [CALCITE-3729] Filters failed to be pushed down when it's identical t… URL: https://github.com/apache/calcite/pull/1753#issuecomment-573572619 How to execute table functions in calcite?? For eg.select * from table(s.multiplication(5,6,5));

[GitHub] [calcite] danny0405 opened a new pull request #1754: [CALCITE-3730] Add hints to RelBuilder

2020-01-13 Thread GitBox
danny0405 opened a new pull request #1754: [CALCITE-3730] Add hints to RelBuilder URL: https://github.com/apache/calcite/pull/1754 * Add hints to RelBuilder * In logical node classes that implement Hintable, add hints to #create method

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365921955 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365921955 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1143: [CALCITE-2884] Implement JSON_INSERT, JSON_REPLACE, JSON_SET URL: https://github.com/apache/calcite/pull/1143#discussion_r365922270 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java

[GitHub] [calcite] XuQianJin-Stars commented on issue #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
XuQianJin-Stars commented on issue #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#issuecomment-573688329 hi @vaibhavjain-dm Thank you very much for your work. Can you rebase your PR for begin review?

[GitHub] [calcite] vaibhavjain-dm opened a new pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
vaibhavjain-dm opened a new pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755 Adding support for IF function for Bigquery, Hive and Spark

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365865552 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +242,19

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365869115 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365850900 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ##

[GitHub] [calcite] jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365858226 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
jinxing64 commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365844024 ## File path: site/_docs/reference.md ## @@ -2331,6 +2334,7 @@ semantics. |

[GitHub] [calcite] jinxing64 commented on issue #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
jinxing64 commented on issue #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#issuecomment-573723698 Please rebase and squash the commits. This is

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365804262 ## File path:

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365857914 ## File path:

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365860310 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ##

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365859669 ## File path:

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#discussion_r365859749 ## File path: site/_docs/reference.md ## @@ -2331,6 +2334,7 @@ semantics.

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365821764 ## File path: core/src/main/java/org/apache/calcite/sql/SqlFunction.java ## @@ -291,6 +291,19 @@

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365826915 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +242,19

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[GitHub] [calcite] vlsi commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365869224 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +244,26 @@ static

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365861912 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +242,19 @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365861912 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +242,19 @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365861839 ## File path: core/src/main/java/org/apache/calcite/sql/SqlFunction.java ## @@ -291,6 +291,19 @@

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r365868477 ## File path: core/src/main/java/org/apache/calcite/sql/SqlFunction.java ## @@ -291,6 +291,19 @@

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[GitHub] [calcite] weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
weidong3630 commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r365819703 ## File path:

[calcite] 02/03: Add method Pair.forEach(Iterable, Iterable, BiConsumer)

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit a55e533be5a0adf4537e98d2e7209fe7bd946ddb Author: Julian Hyde AuthorDate: Tue Oct 8 11:27:00 2019 -0700 Add method

[calcite] branch master updated (dfd8da6 -> 7fafef9)

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from dfd8da6 [CALCITE-3729] Filters failed to be pushed down when it's identical to join condition (Jin Xing) new

[calcite] 01/03: Really deprecate RelBuilder.groupKey(ImmutableBitSet, ImmutableList)

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 315266420ee4113d766af16166a91ac8cb362db0 Author: Julian Hyde AuthorDate: Thu Jan 9 12:33:42 2020 -0800 Really

[calcite] 03/03: Allow "CREATE TABLE ... AS SELECT ..." in Quidem tests

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 7fafef95272e91f97db2a40189fde352720c16e4 Author: Julian Hyde AuthorDate: Sun Oct 6 16:03:54 2019 -0700 Allow

[GitHub] [calcite] julianhyde commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
julianhyde commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r366036818 ## File path:

[GitHub] [calcite] julianhyde commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
julianhyde commented on a change in pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606#discussion_r366056271 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function

2020-01-13 Thread GitBox
amaliujia commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function URL: https://github.com/apache/calcite/pull/1739#discussion_r366039048 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -1072,6 +1072,12 @@

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366125970 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder

2020-01-13 Thread GitBox
danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder URL: https://github.com/apache/calcite/pull/1754#discussion_r366147759 ## File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java ## @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r366133441 ## File path: core/src/main/java/org/apache/calcite/sql/SqlFunction.java ## @@ -291,6 +291,19 @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r366133472 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +244,26 @@

[calcite] 02/02: [CALCITE-3593] JDBC adapter generates incorrect HAVING clause for BigQuery (Jin Xing)

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 3621b61ea0bca953652a2e6d1838e5a296c6a007 Author: jx158167 AuthorDate: Thu Jan 2 19:00:16 2020 +0800 [CALCITE-3593]

[calcite] 01/02: [CALCITE-3466] JDBC adapter incorrectly drops GROUP BY clause of sub-query (Wang Weidong)

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 571cf95a1564c925bf73e4dae3a6c63199b17c4e Author: Wang Weidong AuthorDate: Tue Nov 26 14:45:37 2019 +0800

[GitHub] [calcite] asfgit closed pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true

2020-01-13 Thread GitBox
asfgit closed pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true URL: https://github.com/apache/calcite/pull/1716 This is an automated message

[calcite] branch master updated (7fafef9 -> 3621b61)

2020-01-13 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 7fafef9 Allow "CREATE TABLE ... AS SELECT ..." in Quidem tests new 571cf95 [CALCITE-3466] JDBC adapter

[GitHub] [calcite] asfgit closed pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter.

2020-01-13 Thread GitBox
asfgit closed pull request #1606: [CALCITE-3466] Do not drop the "group by" clause of subquery in a select statement with "group by" clause in JDBC adapter. URL: https://github.com/apache/calcite/pull/1606 This is an

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366124163 ## File path: core/src/main/java/org/apache/calcite/schema/FunctionParameter.java ## @@ -45,7

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366124647 ## File path: core/src/main/java/org/apache/calcite/schema/impl/ReflectiveFunctionBase.java ##

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366123579 ## File path: core/src/main/java/org/apache/calcite/schema/FunctionParameter.java ## @@ -54,14

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366124649 ## File path: core/src/main/java/org/apache/calcite/schema/impl/ReflectiveFunctionBase.java ##

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function

2020-01-13 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1739: [CALCITE-3686] Implement bit_not function URL: https://github.com/apache/calcite/pull/1739#discussion_r366153584 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ## @@ -1072,6

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366126451 ## File path: core/src/test/java/org/apache/calcite/util/Smalls.java ## @@ -368,8 +369,26 @@

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366126394 ## File path: core/src/main/java/org/apache/calcite/schema/Function.java ## @@ -39,6 +39,14 @@

[GitHub] [calcite] gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-01-13 Thread GitBox
gr4ve commented on a change in pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function URL: https://github.com/apache/calcite/pull/1405#discussion_r366126368 ## File path: core/src/main/java/org/apache/calcite/schema/Function.java ## @@ -39,6 +39,14 @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects

2020-01-13 Thread GitBox
ritesh-kapoor commented on a change in pull request #1750: [CALCITE-3726] Allow declaring type objects URL: https://github.com/apache/calcite/pull/1750#discussion_r366132850 ## File path: server/src/test/java/org/apache/calcite/test/ServerTest.java ## @@ -242,6 +242,19 @@

[GitHub] [calcite] XuQianJin-Stars commented on issue #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects

2020-01-13 Thread GitBox
XuQianJin-Stars commented on issue #1755: CALCITE-3731 : Add IF function for BigQuery, Hive and Spark Dialects URL: https://github.com/apache/calcite/pull/1755#issuecomment-574017207 hi @vaibhavjain-dm Before executing `git rebase -i master`, then squash the commits.

[GitHub] [calcite] vlsi commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view URL: https://github.com/apache/calcite/pull/1704#discussion_r366172973 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java

[GitHub] [calcite] vlsi commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view URL: https://github.com/apache/calcite/pull/1704#discussion_r366173108 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableRels.java

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366176531 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366178014 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder

2020-01-13 Thread GitBox
danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder URL: https://github.com/apache/calcite/pull/1754#discussion_r366160219 ## File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java ## @@

[GitHub] [calcite] jinxing64 opened a new pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str…

2020-01-13 Thread GitBox
jinxing64 opened a new pull request #1757: [CALCITE-3716] ResultSetMetaData.getTableName should return empty str… URL: https://github.com/apache/calcite/pull/1757 …ing, not null, when column does not map to a table (Jin Xing)

[calcite] branch master updated (3621b61 -> 81669c5)

2020-01-13 Thread hyuan
This is an automated email from the ASF dual-hosted git repository. hyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 3621b61 [CALCITE-3593] JDBC adapter generates incorrect HAVING clause for BigQuery (Jin Xing) add 81669c5

[GitHub] [calcite] hsyuan closed pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view

2020-01-13 Thread GitBox
hsyuan closed pull request #1704: [CALCITE-3644] Add ProjectSetOpTransposeRule to normalize materialized view URL: https://github.com/apache/calcite/pull/1704 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366176295 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366177681 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366179020 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -4488,6 +4488,37 @@ private

[GitHub] [calcite] vlsi commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder URL: https://github.com/apache/calcite/pull/1754#discussion_r366179960 ## File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java ## @@ -140,7

[GitHub] [calcite] DonnyZone opened a new pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
DonnyZone opened a new pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756 See the discussion in [CALCITE-1824](https://issues.apache.org/jira/browse/CALCITE-1824), we rewrite the query that contains `GROUP_ID` as `UNION-ALL`.

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366174811 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366178638 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366178730 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -5335,6 +5443,11