zabetak commented on issue #1792: [CALCITE-3775] Implicit lookup methods in
SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#issuecomment-585128426
Although I do care a lot about performance the current implementation in
rubenada merged pull request #1796: [CALCITE-3783]
PruneEmptyRules#JOIN_RIGHT_INSTANCE wrong behavior for JoinRelType.ANTI
URL: https://github.com/apache/calcite/pull/1796
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new 10a5b8a [CALCITE-3783]
danny0405 commented on a change in pull request #1790: [CALCITE-3769] Deprecate
TableScanRule
URL: https://github.com/apache/calcite/pull/1790#discussion_r378172547
##
File path: core/src/main/java/org/apache/calcite/tools/RelRunners.java
##
@@ -29,6 +35,19 @@ private
DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378184129
##
File path:
vlsi commented on a change in pull request #1790: [CALCITE-3769] Deprecate
TableScanRule
URL: https://github.com/apache/calcite/pull/1790#discussion_r378197263
##
File path: core/src/main/java/org/apache/calcite/tools/RelRunners.java
##
@@ -29,6 +35,19 @@ private
vlsi commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378214708
##
File path:
zabetak commented on issue #1740: [CALCITE-3713] Remove column names from
Project#digest
URL: https://github.com/apache/calcite/pull/1740#issuecomment-585133377
Since https://issues.apache.org/jira/browse/CALCITE-3785 was logged for this
purpose, I guess we should continue the discussion
DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378211336
##
File path:
vlsi commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378167122
##
File path:
vlsi commented on issue #1740: [CALCITE-3713] Remove column names from
Project#digest
URL: https://github.com/apache/calcite/pull/1740#issuecomment-585166370
I've created https://issues.apache.org/jira/browse/CALCITE-3786 for Digest.
vlsi commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378198948
##
File path:
DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378236745
##
File path:
danny0405 commented on a change in pull request #1790: [CALCITE-3769] Deprecate
TableScanRule
URL: https://github.com/apache/calcite/pull/1790#discussion_r378245164
##
File path: core/src/main/java/org/apache/calcite/tools/RelRunners.java
##
@@ -29,6 +35,19 @@ private
DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378244829
##
File path:
DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378229570
##
File path:
vlsi commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378233204
##
File path:
Aaron edited a comment on issue #1706: CALCITE-3770, minor change
"EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
And one thing I want to for sure, do you
Aaron edited a comment on issue #1706: CALCITE-3770, minor change
"EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
And one thing I want to for sure, do you
dhirenda-gautam commented on a change in pull request #1785: [CALCITE-3771]
TRIM Support for HIVE/SPARK Dialect
URL: https://github.com/apache/calcite/pull/1785#discussion_r378260941
##
File path:
core/src/main/java/org/apache/calcite/sql/dialect/SparkSqlDialect.java
##
Aaron commented on issue #1706: CALCITE-3770, minor change
"EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
DonnyZone commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378229570
##
File path:
vlsi commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378237911
##
File path:
vlsi commented on a change in pull request #1792: [CALCITE-3775] Implicit
lookup methods in SimpleCalciteSchema ignore case sensitivity parameter
URL: https://github.com/apache/calcite/pull/1792#discussion_r378237911
##
File path:
Aaron edited a comment on issue #1706: CALCITE-3770, minor change
"EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585187498
@zabetak OK, thanks a lot, I'll give a look.
And one thing I want to for sure, do you
asereda-gs edited a comment on issue #1798: [CALCITE-2442] Remove .toDelete
cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585375547
I have registered CassandraResource (which implements
asereda-gs commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585370715
@DonnyZone the issue is that cassandra daemon is not properly shutdown after
tests so some files are
vlsi commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra temp
folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585374414
> What I need is a callback after all tests have been executed
I don't think JUnit has a callback
julianhyde commented on issue #1706: CALCITE-3770, minor change
"EnumerableCalcRel" appears in code to "EnumerableCalc".
URL: https://github.com/apache/calcite/pull/1706#issuecomment-585365757
> And one thing I want to for sure, do you think it needs to be modified in
history.md? IMHO, we
asereda-gs commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585375547
I have registered CassandraResource (which implements
asereda-gs commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585406047
@DonnyZone can you pls check now (unfortunately I don't have easy access to
Windows OS runtime) ?
asereda-gs commented on a change in pull request #1798: [CALCITE-2442] Remove
.toDelete cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#discussion_r378515110
##
File path:
asereda-gs commented on a change in pull request #1798: [CALCITE-2442] Remove
.toDelete cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#discussion_r378515748
##
File path:
vlsi commented on a change in pull request #1798: [CALCITE-2442] Remove
.toDelete cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#discussion_r378509609
##
File path:
vlsi commented on a change in pull request #1798: [CALCITE-2442] Remove
.toDelete cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#discussion_r378509030
##
File path:
asereda-gs commented on a change in pull request #1798: [CALCITE-2442] Remove
.toDelete cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#discussion_r378513665
##
File path:
vlsi commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra temp
folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585413865
@asereda-gs , can you please remove this line
asereda-gs closed pull request #775: [CALCITE-2442] Cassandra intermittent test
failures
URL: https://github.com/apache/calcite/pull/775
This is an automated message from the Apache Git Service.
To respond to the message,
asereda-gs commented on a change in pull request #1798: [CALCITE-2442] Remove
.toDelete cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#discussion_r378515748
##
File path:
liyafan82 opened a new pull request #1800: [CALCITE-3790] Make the URL of
FileSource available
URL: https://github.com/apache/calcite/pull/1800
When a FileSource is constructed with only a File object, its URL is left
null. This makes it inconvenient for some scenarios where a valid URL
gr4ve commented on issue #1405: [CALCITE-2772] Support varargs UDF for scalar
function
URL: https://github.com/apache/calcite/pull/1405#issuecomment-585507281
I have merged the latest master commit to this branch
This is an
DonnyZone edited a comment on issue #1798: [CALCITE-2442] Remove .toDelete
cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585513650
Gralde build log in machine 1:
```
> Task :cassandra:test
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 051b6919dfc5b60406e81d5e8b8d5efb263def87
Author: Julian Hyde
AuthorDate: Fri Feb 7 18:10:42 2020 -0800
Add
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit ceb972952739929c175dfd0895407e8e17e0b502
Author: Julian Hyde
AuthorDate: Fri Jan 31 16:57:31 2020 -0800
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 555da953fe758a7d310aeb3aed463f3f2f3cdc3b
Author: Julian Hyde
AuthorDate: Wed Feb 5 17:02:22 2020 -0800
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from a09923f [CALCITE-3785] HepPlanner.belongToDag() doesn't have to use
mapDigestToVertex (Xiening Dai)
new
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585513914
Gradle build log in machine 2.
```
> Task :cassandra:test
FAILURE 0.0sec,
asereda-gs commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585514761
For machine1 logs are fine (`SigarException` is expected). Can you check if
`.toDelete` exists after
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585506346
@asereda-gs I checked this fix on two Windows OS machines. However, it still
fails to delete the
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585513458
`.toDelete` folder is still there.
This
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585516671
I checked both of them, `.toDelete` file exists.
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585517278
asereda-gs commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585522304
Try now pls (refresh your local copy).
On machine1 where startup was successful.
This is an automated email from the ASF dual-hosted git repository.
sereda pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from 555da95 [CALCITE-3774] In RelBuilder and ProjectMergeRule, prevent
merges when it would increase expression
asereda-gs merged pull request #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798
This is an automated message from the Apache Git Service.
hsyuan closed pull request #1799: [CALCITE-3785] HepPlanner.belongToDag()
doesn't have to use mapDigest…
URL: https://github.com/apache/calcite/pull/1799
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
hyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/master by this push:
new a09923f [CALCITE-3785]
asereda-gs commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585510606
By "fails to delete" do you mean throws exception or `.toDelete` folder is
still there ?
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585513650
Build log in machine 1:
```
> Task :cassandra:test
CassandraAdapterDataTypesTest
DonnyZone commented on issue #1798: [CALCITE-2442] Remove .toDelete cassandra
temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585528506
@asereda-gs Thanks! It works well on both machines.
DonnyZone edited a comment on issue #1798: [CALCITE-2442] Remove .toDelete
cassandra temp folder on Windows after tests
URL: https://github.com/apache/calcite/pull/1798#issuecomment-585506346
@asereda-gs I checked this fix on two Windows OS machines. However, it still
fails to delete the
danny0405 commented on a change in pull request #1794: [CALCITE-3781]
HintStrategy can specify excluded rules for planner
URL: https://github.com/apache/calcite/pull/1794#discussion_r378620001
##
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java
danny0405 commented on issue #1803: [CALCITE-3793] AssertionError throws for
planner digest cache key whe…
URL: https://github.com/apache/calcite/pull/1803#issuecomment-585588663
Apache Flink and Apache Druid all the customize type for rel node which is
not a strict type.
danny0405 opened a new pull request #1803: [CALCITE-3793] AssertionError throws
for planner digest cache key whe…
URL: https://github.com/apache/calcite/pull/1803
…n the rel type is not struct
This is an automated message
chunweilei opened a new pull request #1801: [CALCITE-3791] HepPlanner does not
clear metadata cache for the ancestors of discarded node when a transformation
happens
URL: https://github.com/apache/calcite/pull/1801
JIRA: https://issues.apache.org/jira/browse/CALCITE-3791.
danny0405 opened a new pull request #1802: [CALCITE-3792] Remove the generic
type declaration of method
URL: https://github.com/apache/calcite/pull/1802
* The type inference of Scala code 'val mq = cluster.getMetadataQuery'
is failed if we have that generic type declaration for the Java
66 matches
Mail list logo
