[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-25 Thread GitBox
xndai commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r445712632 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -102,41 +99,28 @@ public int size() { */ public static class

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445733718 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445733828 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445734105 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] stalbot opened a new pull request #2045: Some provisional fixes for db2 aliasing issues

2020-06-25 Thread GitBox
stalbot opened a new pull request #2045: URL: https://github.com/apache/calcite/pull/2045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445734744 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445784153 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445733718 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on pull request #1981: [CALCITE-4000] Support OFFSET parameter in TUMBLE/HOP table functions…

2020-06-25 Thread GitBox
amaliujia commented on pull request #1981: URL: https://github.com/apache/calcite/pull/1981#issuecomment-649831503 Rebased on most-recent master. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445352328 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445353311 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445353311 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r445405947 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -64,14 +64,21 @@ g.addEdge("B", "D");

[GitHub] [calcite] rubenada commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r445406357 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -102,41 +99,28 @@ public int size() { */ public static class

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445347641 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445349359 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445351713 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the