[GitHub] [calcite] dawidwys commented on pull request #2042: [CALCITE-4085] Improve nullability support for fields of structured types

2020-06-26 Thread GitBox
dawidwys commented on pull request #2042: URL: https://github.com/apache/calcite/pull/2042#issuecomment-650017811 Do you mind having a look @danny0405 ? This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-26 Thread GitBox
rubenada commented on pull request #2035: URL: https://github.com/apache/calcite/pull/2035#issuecomment-650038139 Thanks for your work @amaliujia ! I think the PR looks good (just need to squash commits). @hsyuan do you want to take a final look?

[GitHub] [calcite] julianhyde commented on pull request #2045: Some provisional fixes for db2 aliasing issues

2020-06-26 Thread GitBox
julianhyde commented on pull request #2045: URL: https://github.com/apache/calcite/pull/2045#issuecomment-650011752 This fix is for case https://issues.apache.org/jira/browse/CALCITE-4090. This is an automated message from

[calcite] branch master updated (6f90aca -> 7e55739)

2020-06-26 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 6f90aca [CALCITE-4087] Hoist, a utility to replace literals in a SQL string with placeholders new dae53ef

[GitHub] [calcite] julianhyde closed pull request #1347: [CALCITE-3224] New RexNode-to-Expression CodeGen Implementation

2020-06-26 Thread GitBox
julianhyde closed pull request #1347: URL: https://github.com/apache/calcite/pull/1347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[calcite] 03/03: [CALCITE-4090] When generating SQL for DB2, a complex SELECT above a sub-query generates a bad table alias (Steven Talbot)

2020-06-26 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit 7e557390a08a583e07faf51ee2c8e03829b57b06 Author: Steven Talbot AuthorDate: Wed Jun 24 16:57:33 2020 -0700

[calcite] 02/03: [CALCITE-4089] In Babel, allow 'CAST(integer AS DATE)' even though it is illegal in Calcite SQL

2020-06-26 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git commit d839a57fc35a4bd46d1ef4d03e67e22db2e802d7 Author: Julian Hyde AuthorDate: Thu Jun 25 09:34:42 2020 -0700

[GitHub] [calcite] julianhyde closed pull request #2045: Some provisional fixes for db2 aliasing issues

2020-06-26 Thread GitBox
julianhyde closed pull request #2045: URL: https://github.com/apache/calcite/pull/2045 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] James-Jeyun-Kim opened a new pull request #2046: [CALCITE-4092] NPE using WITH clause without a corresponding SELECT F…

2020-06-26 Thread GitBox
James-Jeyun-Kim opened a new pull request #2046: URL: https://github.com/apache/calcite/pull/2046 …ROM (James Kim) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] James-Jeyun-Kim commented on pull request #2046: [CALCITE-4092] NPE using WITH clause without a corresponding SELECT F…

2020-06-26 Thread GitBox
James-Jeyun-Kim commented on pull request #2046: URL: https://github.com/apache/calcite/pull/2046#issuecomment-650405565 I deleted the overridden function "resolve" in WithScope.java because that was adding the view from the WITH clause into the scope of the main statement. This made the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-26 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r446320901 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public

[GitHub] [calcite] James-Jeyun-Kim commented on pull request #2046: [CALCITE-4092] NPE using WITH clause without a corresponding SELECT F…

2020-06-26 Thread GitBox
James-Jeyun-Kim commented on pull request #2046: URL: https://github.com/apache/calcite/pull/2046#issuecomment-650403210 This PR catches an invalid WITH clause during the query validation step so that it doesn't lead to a NPE later on in the sqlToRelConverter stage.