[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-28 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r446743961 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1161,49 @@ public static boolean equalSansNullability(

[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-28 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r446743935 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1161,49 @@ public static boolean equalSansNullability(

[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-28 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r446743740 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] zabetak commented on pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

2020-06-28 Thread GitBox
zabetak commented on pull request #2009: URL: https://github.com/apache/calcite/pull/2009#issuecomment-650835726 > Forgive me for being rather pedantic. This looks great. Just a few small suggested changes. Thanks for the second pair of eyes @michaelmior and @chunweilei , much

[GitHub] [calcite] danny0405 commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-28 Thread GitBox
danny0405 commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r446744526 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +126,37 @@

[GitHub] [calcite] michaelmior merged pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-28 Thread GitBox
michaelmior merged pull request #2021: URL: https://github.com/apache/calcite/pull/2021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[calcite] branch master updated: [CALCITE-3929] When deserialize UDAF aggregate call from json string, throws NPE (Xu Zhaohui)

2020-06-28 Thread mmior
This is an automated email from the ASF dual-hosted git repository. mmior pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new da71139 [CALCITE-3929] When deserialize UDAF

[GitHub] [calcite] yanlin-Lynn commented on pull request #2021: [CALCITE-3929] When deserialize UDAF aggregate call from json string,…

2020-06-28 Thread GitBox
yanlin-Lynn commented on pull request #2021: URL: https://github.com/apache/calcite/pull/2021#issuecomment-650744525 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite] branch master updated: [CALCITE-3941] Add the default strict mode to the path in the Json functions

2020-06-28 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 057186d [CALCITE-3941] Add the default

[GitHub] [calcite] chunweilei merged pull request #1955: [CALCITE-3941] Add the default strict mode to the path in the Json functions

2020-06-28 Thread GitBox
chunweilei merged pull request #1955: URL: https://github.com/apache/calcite/pull/1955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go