[GitHub] [calcite] julianhyde opened a new pull request #2047: [CALCITE-3936] JDBC adapter, when generating SQL, changes target of ambiguous HAVING clause with a Project on Filter on Aggregate

2020-06-29 Thread GitBox
julianhyde opened a new pull request #2047: URL: https://github.com/apache/calcite/pull/2047 In order to fix https://issues.apache.org/jira/browse/CALCITE-3936, we needed significant refactoring of `SqlImplementor` and `RelToSqlConverter`. There are various changes to the signatures

[GitHub] [calcite] amaliujia commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-29 Thread GitBox
amaliujia commented on pull request #2035: URL: https://github.com/apache/calcite/pull/2035#issuecomment-650995914 @rubenada I think this PR is ready to merge. I have rebased and squashed commits! This is an automated

[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-29 Thread GitBox
rubenada commented on pull request #2035: URL: https://github.com/apache/calcite/pull/2035#issuecomment-650978346 Thanks @hsyuan . @amaliujia do you think there is any other issue to be addressed? Could we consider squash commits and merge?

[GitHub] [calcite] rubenada commented on pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-29 Thread GitBox
rubenada commented on pull request #2027: URL: https://github.com/apache/calcite/pull/2027#issuecomment-651023112 @xndai do you have any other comments regarding this PR? I think it is in a pretty good shape, we could consider to merge it (after squashing commits into a single on).

[GitHub] [calcite] rubenada commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-29 Thread GitBox
rubenada commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r446867196 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -64,14 +64,21 @@ g.addEdge("B", "D");

[GitHub] [calcite] rubenada commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-29 Thread GitBox
rubenada commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r446864534 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -102,41 +99,28 @@ public int size() { */ public static class

[calcite] branch master updated: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregate (Rui Wang).

2020-06-29 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new bf9ff00 [CALCITE-4008] Implement Code

[GitHub] [calcite] rubenada merged pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-29 Thread GitBox
rubenada merged pull request #2035: URL: https://github.com/apache/calcite/pull/2035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] rubenada commented on pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-29 Thread GitBox
rubenada commented on pull request #2035: URL: https://github.com/apache/calcite/pull/2035#issuecomment-651017132 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] zinking commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-29 Thread GitBox
zinking commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-651180505 LGTM, how about adding a test that isn't within mysql's SQL syntax support but gets supported through this adapter ?

[GitHub] [calcite] xndai commented on pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-29 Thread GitBox
xndai commented on pull request #2027: URL: https://github.com/apache/calcite/pull/2027#issuecomment-651237132 Looks good to me. Thanks @rubenada and @liyafan82 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369381 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1161,49 @@ public static boolean equalSansNullability(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369330 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r447369045 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +126,37 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369330 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] liyafan82 commented on pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-29 Thread GitBox
liyafan82 commented on pull request #2027: URL: https://github.com/apache/calcite/pull/2027#issuecomment-651495510 @rubenada @xndai Thanks a lot for your good comments. I have squashed the commits into one. This is an

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r447369045 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +126,37 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369330 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #2037: [CALCITE-3834] Support AntiJoin in EnumerableMergeJoin

2020-06-29 Thread GitBox
hsyuan commented on a change in pull request #2037: URL: https://github.com/apache/calcite/pull/2037#discussion_r447379011 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -3878,6 +3879,8 @@ public void remove() { private final

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-29 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-651476622 @zinking Thanks for reviewing! Could you give me some testing SQL examples and maybe explain the meaning behind this?

[GitHub] [calcite] qizhou92 opened a new pull request #2048: [CALCITE-3913] Test correctness using formal verification (Qi Zhou).

2020-06-29 Thread GitBox
qizhou92 opened a new pull request #2048: URL: https://github.com/apache/calcite/pull/2048 Add dependency for z3, add two simple tests to test if native library work. I am new to this process, and I am not quite sure how much code I should push in commit to reviewing. Welcome any