[GitHub] [calcite] rubenada commented on a change in pull request #2037: [CALCITE-3834] Support AntiJoin in EnumerableMergeJoin

2020-06-30 Thread GitBox
rubenada commented on a change in pull request #2037: URL: https://github.com/apache/calcite/pull/2037#discussion_r447452267 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -3878,6 +3879,8 @@ public void remove() { private final

[GitHub] [calcite] rubenada commented on pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-30 Thread GitBox
rubenada commented on pull request #2027: URL: https://github.com/apache/calcite/pull/2027#issuecomment-651583172 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[calcite] branch master updated: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-30 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new bd121aa [CALCITE-4049] Improve the

[GitHub] [calcite] rubenada merged pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-30 Thread GitBox
rubenada merged pull request #2027: URL: https://github.com/apache/calcite/pull/2027 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-30 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447636635 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] zinking commented on a change in pull request #1946: [CALCITE-3539] Implement INSTR function

2020-06-30 Thread GitBox
zinking commented on a change in pull request #1946: URL: https://github.com/apache/calcite/pull/1946#discussion_r447658773 ## File path: site/_docs/reference.md ## @@ -2359,6 +2359,7 @@ semantics. | m | SPACE(integer) | Returns a string of

[GitHub] [calcite] zinking commented on pull request #1929: Add CheckerFramework to GitHub Actions CI

2020-06-30 Thread GitBox
zinking commented on pull request #1929: URL: https://github.com/apache/calcite/pull/1929#issuecomment-65135 > You are right, there's not enough annotations. > The idea was that once all the annotations are there, we could enforce the check for all the commits. > > Feel free

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-30 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-651833186 In MySQL 5.6, `COMPACT` is the default row format. After MySQL 5.7 (include 8.0), `DYNAMIC` is the default row format. The two are the most popular row formats. For

[GitHub] [calcite] zinking commented on pull request #1946: [CALCITE-3539] Implement INSTR function

2020-06-30 Thread GitBox
zinking commented on pull request #1946: URL: https://github.com/apache/calcite/pull/1946#issuecomment-651772100 looks good overall This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] zinking edited a comment on pull request #1929: Add CheckerFramework to GitHub Actions CI

2020-06-30 Thread GitBox
zinking edited a comment on pull request #1929: URL: https://github.com/apache/calcite/pull/1929#issuecomment-65135 > You are right, there's not enough annotations. > The idea was that once all the annotations are there, we could enforce the check for all the commits. > >

[GitHub] [calcite] XuQianJin-Stars commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-30 Thread GitBox
XuQianJin-Stars commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-651808436 hi @neoremind Have you considered that row_format has some other values: `default` `fixed` `dynamic` `compressed` `extra` `compact`

[GitHub] [calcite] zinking commented on a change in pull request #1944: [CALCITE-3956] Unify comparison logic for RelOptCost

2020-06-30 Thread GitBox
zinking commented on a change in pull request #1944: URL: https://github.com/apache/calcite/pull/1944#discussion_r447663248 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptCost.java ## @@ -76,19 +132,28 @@ /** * Compares this to another cost. + * This

[GitHub] [calcite] amaliujia commented on pull request #2025: [CALCITE-4033] Does not produce parenthesized table expressions for U…

2020-06-30 Thread GitBox
amaliujia commented on pull request #2025: URL: https://github.com/apache/calcite/pull/2025#issuecomment-652069459 @danny0405 is it now the right time to merge this PR? This is an automated message from the Apache Git

[calcite] branch master updated: Site: Add instructions for managing Calcite repos through GitHub

2020-06-30 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3e7349f Site: Add instructions for managing

[GitHub] [calcite] zabetak closed pull request #2009: Site: Add instructions for managing Calcite repos through GitHub

2020-06-30 Thread GitBox
zabetak closed pull request #2009: URL: https://github.com/apache/calcite/pull/2009 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] XuQianJin-Stars commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-30 Thread GitBox
XuQianJin-Stars commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-652137425 hi @neoremind Sorry I haven't finished the review yet, I will continue to take the time to complete. This PR looks pretty good overall.

[calcite] 01/03: Improve 1.23.0 release note and document

2020-06-30 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git commit d0ee89a068c451a2c52f3140c09778970ceb10fb Author: Haisheng Yuan AuthorDate: Sat May 23 13:10:59 2020 -0500 Improve

[calcite] branch site updated (b708fdc -> a171fe4)

2020-06-30 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a change to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git. from b708fdc [CALCITE-3989] Release Calcite 1.23.0 new d0ee89a Improve 1.23.0 release note and document new

[calcite] 02/03: Add 1.23.0 release announcement

2020-06-30 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git commit 50a2f95deede6e680fc02953e97a75e14b0f940c Author: Haisheng Yuan AuthorDate: Sat May 23 22:23:51 2020 -0500 Add

[calcite] 03/03: Site: Add instructions for managing Calcite repos through GitHub

2020-06-30 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git commit a171fe4b3d0f374877f6ac028056d405520b1bff Author: Stamatis Zampetakis AuthorDate: Fri Jun 5 12:36:42 2020 +0200

[calcite-site] branch master updated: Site: Add instructions for managing Calcite repos through GitHub

2020-06-30 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/master by this push: new 2bb32ed Site: Add instructions for

[GitHub] [calcite] XuQianJin-Stars commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-30 Thread GitBox
XuQianJin-Stars commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-652136500 hi @neoremind What is the production usage scenario of this MySQL InnoDB Java Reader? This is an

[GitHub] [calcite] zabetak opened a new pull request #2050: Site: Remove '(for Calcite committers)' suffix from headers in section dedicated to committers

2020-06-30 Thread GitBox
zabetak opened a new pull request #2050: URL: https://github.com/apache/calcite/pull/2050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] hsyuan opened a new pull request #2051: [CALCITE-4097] Avoid requesting unnecessary trait request when deriving traits

2020-06-30 Thread GitBox
hsyuan opened a new pull request #2051: URL: https://github.com/apache/calcite/pull/2051 If the child subset is used to derive new traits for current relnode, the subset will be marked REQUIRED when registering the new derived relnode and later will add enforcers between other

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-30 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1996: URL: https://github.com/apache/calcite/pull/1996#discussion_r447719202 ## File path: innodb/src/main/java/org/apache/calcite/adapter/innodb/QueryType.java ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] danny0405 closed pull request #2025: [CALCITE-4033] Does not produce parenthesized table expressions for U…

2020-06-30 Thread GitBox
danny0405 closed pull request #2025: URL: https://github.com/apache/calcite/pull/2025 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-06-30 Thread GitBox
chunweilei commented on a change in pull request #2030: URL: https://github.com/apache/calcite/pull/2030#discussion_r448088033 ## File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java ## @@ -385,6 +385,34 @@ + " ]\n" + "}"; + public static

[GitHub] [calcite] Aaaaaaron commented on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

2020-06-30 Thread GitBox
Aaron commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652148774 > you are changing the code, worth a jira for this PR. Thanks for your advice This is an automated

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-30 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448079966 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[calcite] branch master updated: [CALCITE-4033] Does not produce parenthesized table expressions for UNNEST (Rui Wang)

2020-06-30 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 2d6e57f [CALCITE-4033] Does not produce

[GitHub] [calcite] danny0405 commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-30 Thread GitBox
danny0405 commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448083189 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] yanlin-Lynn commented on pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-06-30 Thread GitBox
yanlin-Lynn commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652156774 make sense, +1 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] chunweilei commented on pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

2020-06-30 Thread GitBox
chunweilei commented on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-652159186 Please refer the doc[1] about the format of commit message. [1]https://calcite.apache.org/develop/#contributing