[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448732591 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,34 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448440265 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448439014 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-07-01 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448438918 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-30 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r448079966 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,45 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369330 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369330 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369330 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +120,47 @@

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r447369381 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1161,49 @@ public static boolean equalSansNullability(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-20 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r443140920 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1160,59 @@ public static boolean equalSansNullability(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-20 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r443140543 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1160,59 @@ public static boolean equalSansNullability(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-20 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r443140543 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1160,6 +1160,59 @@ public static boolean equalSansNullability(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-17 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r441301149 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1510,6 +1563,31 @@ public static boolean isMap(RelDataType type) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-17 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r441298797 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1510,6 +1563,31 @@ public static boolean isMap(RelDataType type) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-17 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r441298797 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1510,6 +1563,31 @@ public static boolean isMap(RelDataType type) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-15 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r440571689 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1151,13 +1151,22 @@ public static boolean equalSansNullability(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2019: [CALCITE-4059] SqlTypeUtil#equalSansNullability consider Array/Map type.

2020-06-15 Thread GitBox
Aaron commented on a change in pull request #2019: URL: https://github.com/apache/calcite/pull/2019#discussion_r440569282 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1151,13 +1151,22 @@ public static boolean equalSansNullability(