[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r447369045 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +126,37 @@ SqlTypeCoercionRule.THREAD_PROVIDERS.set(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-29 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r447369045 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +126,37 @@ SqlTypeCoercionRule.THREAD_PROVIDERS.set(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-22 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r443587411 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1038,19 +1043,40 @@ public static SqlDataTypeSpec convertTypeToSpe

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-21 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r443304859 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +126,37 @@ SqlTypeCoercionRule.THREAD_PROVIDERS.set(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-19 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r442679115 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +131,57 @@ SqlTypeCoercionRule.THREAD_PROVIDERS.set(

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2029: [CALCITE-4066] SqlTypeUtil#convertTypeToSpec cover Array/Multiset/Row types.

2020-06-19 Thread GitBox
Aaron commented on a change in pull request #2029: URL: https://github.com/apache/calcite/pull/2029#discussion_r442679115 ## File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java ## @@ -117,6 +131,57 @@ SqlTypeCoercionRule.THREAD_PROVIDERS.set(