[GitHub] [calcite] DonnyZone commented on issue #1806: Following [CALCITE-3763] Fix slow test failure
DonnyZone commented on issue #1806: Following [CALCITE-3763] Fix slow test failure URL: https://github.com/apache/calcite/pull/1806#issuecomment-586687362 Thanks, updated. It seems that ES test fails easily due to timeout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] DonnyZone commented on issue #1806: Following [CALCITE-3763] Fix slow test failure
DonnyZone commented on issue #1806: Following [CALCITE-3763] Fix slow test failure URL: https://github.com/apache/calcite/pull/1806#issuecomment-586561138 It is too tiny to fire a discussion. As what you do for CALCITE-3769 (i.e., changing the expected plan string from `LogicalTableScan` to `StarTableScan`), why do we not do the same thing for `testLatticeStarTable`? Because removing this extra `Project` is the expected result of CALCITE-3763. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] DonnyZone commented on issue #1806: Following [CALCITE-3763] Fix slow test failure
DonnyZone commented on issue #1806: Following [CALCITE-3763] Fix slow test failure URL: https://github.com/apache/calcite/pull/1806#issuecomment-586488735 From my personal view, since CALCITE-3763 prunes extra projects, we'd better modify the expected plan string as you do for CALCITE-3769. On the other hand, checking “CannotPlanException” is generally used in LatticeTest to indicate match failure, therefore, checking “Assertion” seems to be meaningless. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
