[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-06-12 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1227350034 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6823,50 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-29 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1209078369 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -3549,7 +3549,17 @@ protected final void createAggImpl( // implement HAVING (we

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-29 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1209077887 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-29 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1209076981 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6823,48 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-25 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1205057374 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6823,48 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-25 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1205054838 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-25 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1205043890 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -3549,7 +3549,17 @@ protected final void createAggImpl( // implement HAVING (we

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-23 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1202516946 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -3549,7 +3549,17 @@ protected final void createAggImpl( // implement HAVING (we

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-23 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1202515386 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-23 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1202371411 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-12 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1192598969 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-10 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1190174369 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {