[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-26 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r446320901 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445733718 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445784153 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445734744 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445734105 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445733718 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445733828 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-24 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445213183 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-24 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445212926 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-23 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r444658998 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-23 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r444658637 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-23 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r444657447 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-18 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r442417140 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-18 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r442417140 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] amaliujia commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-18 Thread GitBox
amaliujia commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r442416752 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public