[GitHub] [calcite] amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement

2020-01-24 Thread GitBox
amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement URL: https://github.com/apache/calcite/pull/1763#issuecomment-578235585 The Oracle's documentation is a good reference. +1 on this PR. -

[GitHub] [calcite] amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement

2020-01-15 Thread GitBox
amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement URL: https://github.com/apache/calcite/pull/1763#issuecomment-574961200 That wasn't the use case I was thinking of but I got what you meant. So basically you think python script should sor

[GitHub] [calcite] amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement

2020-01-15 Thread GitBox
amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement URL: https://github.com/apache/calcite/pull/1763#issuecomment-574959845 oops! Agreed with the relation algebra (table by default does not have an ordering) I was thinking the

[GitHub] [calcite] amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement

2020-01-15 Thread GitBox
amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement URL: https://github.com/apache/calcite/pull/1763#issuecomment-574944740 @hsuanyi that's an interesting perspective. Will the ordering depends on sinks? For example, insert into a log file

[GitHub] [calcite] amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement

2020-01-15 Thread GitBox
amaliujia commented on issue #1763: [CALCITE-3738] Missing order by logical plan for insert statement URL: https://github.com/apache/calcite/pull/1763#issuecomment-574920385 LGTM thanks! This is an automated message from the