[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox 
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] 
HiveSqlDialect unparse Interger type as Int in order to be compatible for 
Hive1.x
URL: https://github.com/apache/calcite/pull/1443#discussion_r322613572
 
 

 ##
 File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
 ##
 @@ -749,6 +749,9 @@ public boolean supportsDataType(RelDataType type) {
 return true;
   }
 
+ /** Returns SqlNode for type in "cast(column as type)" , which is different
 
 Review comment:
   > which is different in every kind of database such as type name, precision 
etc.
   
   How about:
   which might be different between databases by type name, precision etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox 
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] 
HiveSqlDialect unparse Interger type as Int in order to be compatible for 
Hive1.x
URL: https://github.com/apache/calcite/pull/1443#discussion_r322612947
 
 

 ##
 File path: core/src/main/java/org/apache/calcite/sql/SqlDialect.java
 ##
 @@ -749,6 +749,9 @@ public boolean supportsDataType(RelDataType type) {
 return true;
   }
 
+ /** Returns SqlNode for type in "cast(column as type)" , which is different
 
 Review comment:
   Not sure, shall we wrap `cast ...` with `{@code}`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox 
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] 
HiveSqlDialect unparse Interger type as Int in order to be compatible for 
Hive1.x
URL: https://github.com/apache/calcite/pull/1443#discussion_r322614547
 
 

 ##
 File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
 ##
 @@ -1009,6 +1009,7 @@ private static boolean flattenFields(
 return nested;
   }
 
+
   /**
 
 Review comment:
   No need to add this line ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox 
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] 
HiveSqlDialect unparse Interger type as Int in order to be compatible for 
Hive1.x
URL: https://github.com/apache/calcite/pull/1443#discussion_r322614745
 
 

 ##
 File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
 ##
 @@ -1054,7 +1055,7 @@ public static SqlDataTypeSpec 
convertTypeToSpec(RelDataType type,
* @param type type descriptor
* @return corresponding parse representation
*/
-  public static SqlDataTypeSpec convertTypeToSpec(RelDataType type) {
+  public static SqlDataTypeSpec  convertTypeToSpec(RelDataType type) {
 
 Review comment:
   No necessary change ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services