[GitHub] [calcite] jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.
jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#issuecomment-521875383 Thanks for approve ~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.
jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#issuecomment-521874308 Thanks @hsyuan for review this ~ I refined by your comments and squashed the comments :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [calcite] jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching.
jinxing64 commented on issue #1333: [CALCITE-3214] Add UnionToUnionRule for materialization matching. URL: https://github.com/apache/calcite/pull/1333#issuecomment-520202981 @hsyuan Thanks for looking into this ~ After this change -- https://github.com/apache/calcite/pull/1310 , there's no strict column name checking but only column count and column type checking (`SubstitutionVisitor::rowTypesAreEquivalent`). Do you think there's strong need to keep the column name same during materialization matching? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
