[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-27 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r446590701 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -102,41 +99,28 @@ public int size() { */ public static class

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-27 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r446590442 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -64,14 +64,21 @@ g.addEdge("B", "D");

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-18 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442101018 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -66,7 +66,7 @@ assertNull(shortestPath(g, "A", "E"),

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-18 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442100756 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -134,7 +135,44 @@ public int size() { if (from.equals(to)) {

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-18 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442019191 ## File path: core/src/main/java/org/apache/calcite/plan/ConventionTraitDef.java ## @@ -234,10 +234,10 @@ private ConversionData

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-17 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r441518623 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -56,42 +54,40 @@ public int size() { public static FrozenGraph

[GitHub] [calcite] liyafan82 commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-17 Thread GitBox
liyafan82 commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r441518399 ## File path: core/src/main/java/org/apache/calcite/plan/ConventionTraitDef.java ## @@ -234,10 +234,10 @@ private ConversionData