liyafan82 commented on pull request #1944:
URL: https://github.com/apache/calcite/pull/1944#issuecomment-814807518
Since we have not reached an agreement in the discussion, I am closing the
issue.
Thank all reviewers for the feedback.
--
This is an automated message from the Apache
liyafan82 commented on pull request #1944:
URL: https://github.com/apache/calcite/pull/1944#issuecomment-652971498
> LGTM, but any issue with changing the interface with default logic ?
Thanks a lot for you feedback.
We want to prevent the client from overriding the default com
liyafan82 commented on pull request #1944:
URL: https://github.com/apache/calcite/pull/1944#issuecomment-652837339
After more thoughts and discussions, we have changed the design in another
way:
1. The RelOptCost interface is left unchanged.
2. Add an abstract class that implemen
liyafan82 commented on pull request #1944:
URL: https://github.com/apache/calcite/pull/1944#issuecomment-652392499
> > > I don't see interface definition needs to be changed, the change
should be made in the IMPlementation file.
> >
> >
> > @zinking Thanks for your good suggestio
liyafan82 commented on pull request #1944:
URL: https://github.com/apache/calcite/pull/1944#issuecomment-652273329
> I don't see interface definition needs to be changed, the change should be
made in the IMPlementation file.
@zinking Thanks for your good suggestion. I have reverted t
liyafan82 commented on pull request #1944:
URL: https://github.com/apache/calcite/pull/1944#issuecomment-619469065
> Let's continue discussion on JIRA before moving on
Agreed. Thank you.
This is an automated message fr
