[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-08-17 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-674738512 @XuQianJin-Stars I have addressed the comments from Julian (discussion in JIRA), and made the latest code compatible with 1.25.0, the binary files are not a concern anymore. A

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-08-17 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-674720876 I have refactored some of the code to use the new API (in 1.25.0), to create and parameterized innodb planner rules. Please refer to https://issues.apache.org/jira/browse/CALC

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-07-01 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-652330139 @XuQianJin-Stars I have addressed the comments above. For the question: *What is the production usage scenario of this MySQL InnoDB Java Reader?* Calcite's InnoDB ada

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-30 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-651833186 In MySQL 5.6, `COMPACT` is the default row format. After MySQL 5.7 (include 8.0), `DYNAMIC` is the default row format. The two are the most popular row formats. For `

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-29 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-651476622 @zinking Thanks for reviewing! Could you give me some testing SQL examples and maybe explain the meaning behind this?

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-09 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-641320784 @XuQianJin-Stars No hurry, take your time, thanks very much! This is an automated message from the Apache Git

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-04 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-638970225 @XuQianJin-Stars I have rebased master, did some refinement and updated `innodb_adapter.md`, for how the adapter works, please refer to `innodb_adapter.md`, I think this doc e

[GitHub] [calcite] neoremind commented on pull request #1996: [CALCITE-4034] Implement a MySQL InnoDB adapter

2020-06-01 Thread GitBox
neoremind commented on pull request #1996: URL: https://github.com/apache/calcite/pull/1996#issuecomment-636909734 @XuQianJin-Stars many thanks 😃 This is an automated message from the Apache Git Service. To respond to the me