[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445351713 ## File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableSortedAggregateTest.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445352328 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445353311 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445353311 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,132 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445349359 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-25 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r445347641 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-24 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r444744863 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-24 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r444738980 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443486637 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443451500 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443446065 ## File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java ## @@ -817,6 +817,112 @@ public void remove() {

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443406186 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public

[GitHub] [calcite] rubenada commented on a change in pull request #2035: [CALCITE-4008] Implement Code generation for EnumerableSortedAggregat…

2020-06-22 Thread GitBox
rubenada commented on a change in pull request #2035: URL: https://github.com/apache/calcite/pull/2035#discussion_r443406186 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSortedAggregate.java ## @@ -90,6 +101,133 @@ public