[GitHub] [calcite] rubenada commented on pull request #2411: Add generic info to Map & Array annotation

2021-05-26 Thread GitBox 


rubenada commented on pull request #2411:
URL: https://github.com/apache/calcite/pull/2411#issuecomment-848536331


   Thanks @tisonkun for the patch and for the detailed explanation!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2411: Add generic info to Map & Array annotation

2021-05-25 Thread GitBox 


rubenada commented on pull request #2411:
URL: https://github.com/apache/calcite/pull/2411#issuecomment-847844526


   Thanks for the confirmation @zabetak 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [calcite] rubenada commented on pull request #2411: Add generic info to Map & Array annotation

2021-05-25 Thread GitBox 


rubenada commented on pull request #2411:
URL: https://github.com/apache/calcite/pull/2411#issuecomment-847740202


   This patch could be merged, but there is no associated Jira. Since it is a 
small change, perhaps we could make an exception, what do you think @zabetak ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org