Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-25 Thread via GitHub


mihaibudiu merged PR #4659:
URL: https://github.com/apache/calcite/pull/4659


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-24 Thread via GitHub


iwanttobepowerful commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3690774527

   Thanks. @xiedeyantu @mihaibudiu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-24 Thread via GitHub


xiedeyantu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3690760084

   The button is now working properly, and you can merge them at any time. 
@mihaibudiu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-24 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3690757599

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.4% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-24 Thread via GitHub


xiedeyantu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3690588626

   I can't find a viable solution. Perhaps you could try force pushing again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-24 Thread via GitHub


xiedeyantu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3690580557

   > I don't understand why the merge button is disabled.
   
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-24 Thread via GitHub


mihaibudiu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3690381300

   I don't understand why the merge button is disabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-23 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3688789492

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.4% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-23 Thread via GitHub


iwanttobepowerful commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3688102155

   > This also has a conflict now, please rebase and fix and I will merge.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-23 Thread via GitHub


mihaibudiu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3688097441

   This also has a conflict now, please rebase and fix and I will merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-23 Thread via GitHub


mihaibudiu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3687502158

   Can you rebase so we can just make sure all CI tests pass?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-23 Thread via GitHub


mihaibudiu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3687499630

   Maybe it was due to github problems, yesterday they had quite a few


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-23 Thread via GitHub


mihaibudiu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3687498196

   The checker framework seems to have failed, do you want to look into it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-22 Thread via GitHub


mihaibudiu commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3684393302

   Last chance to make comments before merging!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-22 Thread via GitHub


iwanttobepowerful commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3682066529

   > I will approve this
   
   I think this PR is ready to be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-22 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3682054315

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.4% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-14 Thread via GitHub


iwanttobepowerful commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3650942857

   @mihaibudiu @suibianwanwank 
   Hi there, could you please review this PR? I think it’s ready for review now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-13 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3649965548

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.4% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-13 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3649960337

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-13 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3649581799

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-13 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3649493411

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [89.2% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-13 Thread via GitHub


iwanttobepowerful commented on code in PR #4659:
URL: https://github.com/apache/calcite/pull/4659#discussion_r2616313552


##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1772,8 +1772,11 @@ private static boolean isWidening(RelDataType type, 
RelDataType type1) {
   return null;
 }
 
+
+Frame newLeftFrame = getNewLeftFrame(rel, oldLeft, leftFrame, 
isCorVarDefined);

Review Comment:
   how about oldRight?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-12 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3646469548

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [91.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-09 Thread via GitHub


iwanttobepowerful commented on code in PR #4659:
URL: https://github.com/apache/calcite/pull/4659#discussion_r2605087925


##
core/src/test/resources/sql/sub-query.iq:
##
@@ -5504,5 +5504,151 @@ WHERE EXISTS
 +-+
 (2 rows)
 
+!ok
+
+# [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains 
RexFieldAccess
+SELECT E1.ENAME
+FROM EMP E1
+WHERE
+  E1.SAL > (SELECT D1.DEPTNO FROM
+  DEPT D1 JOIN EMP E2

Review Comment:
   need add test cases that have other join type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-09 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3632135552

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [89.1% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-09 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3632036159

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [91.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-07 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3625182584

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [91.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-01 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3600659920

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [91.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-01 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3600562847

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [91.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-01 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3600478427

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [91.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-01 Thread via GitHub


sonarqubecloud[bot] commented on PR #4659:
URL: https://github.com/apache/calcite/pull/4659#issuecomment-3600473567

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [1 New 
issue](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4659&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4659&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [92.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4659&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4659)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] [CALCITE-7257] Subqueries cannot be decorrelated if join condition contains RexFieldAccess [calcite]

2025-12-01 Thread via GitHub


iwanttobepowerful opened a new pull request, #4659:
URL: https://github.com/apache/calcite/pull/4659

   CALCITE-7257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]