Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on PR #3589: URL: https://github.com/apache/calcite/pull/3589#issuecomment-2065329884 I have submitted https://github.com/apache/calcite/pull/3764, which provides just a fix for [CALCITE-6169]. Once that is merged, I will resubmit a much smaller PR here to fix

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on code in PR #3589: URL: https://github.com/apache/calcite/pull/3589#discussion_r1528991914 ## core/src/main/java/org/apache/calcite/rex/RexBuilder.java: ## @@ -699,22 +699,23 @@ boolean canRemoveCastFromLiteral(RelDataType toType, @Nullable Comparable

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

jduo commented on code in PR #3589: URL: https://github.com/apache/calcite/pull/3589#discussion_r1528985794 ## core/src/main/java/org/apache/calcite/rex/RexBuilder.java: ## @@ -699,22 +699,23 @@ boolean canRemoveCastFromLiteral(RelDataType toType, @Nullable Comparable value,

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on PR #3589: URL: https://github.com/apache/calcite/pull/3589#issuecomment-1969568419 @libenchao I have added some review comments to this PR, if you can help with a review we can hopefully merge this. Thank you. -- This is an automated message from the Apache Git

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on code in PR #3589: URL: https://github.com/apache/calcite/pull/3589#discussion_r1506378183 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java: ## @@ -406,11 +407,24 @@ public static Expression convert(Expression operand, Type

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on code in PR #3589: URL: https://github.com/apache/calcite/pull/3589#discussion_r1506248012 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -3334,20 +,11 @@ private void registerOperandSubQueries( @Override public

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on PR #3589: URL: https://github.com/apache/calcite/pull/3589#issuecomment-1911208876 If anyone wants to do a pair review we can arrange a short meeting so I can explain what's going on. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on PR #3589: URL: https://github.com/apache/calcite/pull/3589#issuecomment-1911187494 This bugfix is also ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

mihaibudiu commented on PR #3589: URL: https://github.com/apache/calcite/pull/3589#issuecomment-1869784859 Thank you @tanclary for the review, I pushed a new commit which hopefully addresses your comments. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CALCITE-3522] Sql validator limits decimal literals to 64 bits and [CALCITE-6169] EnumUtils.convert does not implement the correct SQL cast semantics [calcite]

tanclary commented on code in PR #3589: URL: https://github.com/apache/calcite/pull/3589#discussion_r1435829039 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -3334,20 +,11 @@ private void registerOperandSubQueries( @Override public