Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]

2023-10-09 Thread via GitHub
ian-bertolacci commented on code in PR #3452: URL: https://github.com/apache/calcite/pull/3452#discussion_r1350768855 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java: ## @@ -666,6 +666,29 @@ static class JoinConditionBasedPredicateInference {

Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]

2023-10-05 Thread via GitHub
LakeShen commented on PR #3452: URL: https://github.com/apache/calcite/pull/3452#issuecomment-1748326807 More details could see developing Calcite guide:https://calcite.apache.org/develop/ -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]

2023-10-04 Thread via GitHub
sonarcloud[bot] commented on PR #3452: URL: https://github.com/apache/calcite/pull/3452#issuecomment-1747643124 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]

2023-10-04 Thread via GitHub
keatn commented on code in PR #3452: URL: https://github.com/apache/calcite/pull/3452#discussion_r1346428537 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java: ## @@ -666,6 +666,29 @@ static class JoinConditionBasedPredicateInference {

Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]

2023-10-04 Thread via GitHub
keatn commented on code in PR #3452: URL: https://github.com/apache/calcite/pull/3452#discussion_r1346428283 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java: ## @@ -666,6 +666,29 @@ static class JoinConditionBasedPredicateInference {