[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-789031361 I'll merge as I'd like to not have to rebase this one again... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-789024955 Woah! A successful build :sweat_smile: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788935971 Added the additional config to the `ServiceMonitor` (hopefully correctly). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788858497 @astefanutti are we good to merge this one? The usual flaky tests failed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-788792687 Conflicts resolved. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-787786140 I don't understand why there are random failures in the YAKS knative tests. They don't occur for me locally. I've put this PR back into review and it's good to merge IMO. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-765457997 Seems a Spectrum tweak is also required, so opened https://github.com/container-tools/spectrum/pull/4. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764723809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764766938 > Does the image run successfully? Yes, that part works. The integration tests verify that and I did some of my own testing on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764743929 Here's some example output from `kamel inspect examples/Sample.java --all-dependencies`. ``` /tmp/maven-485089909/target/quarkus-app/app/camel-k-integration-1.4.0-SNAPSHOT.jar /tmp/maven-485089909/target/quarkus-app/lib/boot/io.quarkus.quarkus-bootstrap-runner-1.11.0.Final.jar /tmp/maven-485089909/target/quarkus-app/lib/boot/io.quarkus.quarkus-development-mode-spi-1.11.0.Final.jar /tmp/maven-485089909/target/quarkus-app/lib/boot/io.smallrye.common.smallrye-common-io-1.5.0.jar /tmp/maven-485089909/target/quarkus-app/lib/boot/org.jboss.logging.jboss-logging-3.4.1.Final.jar ... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764726552 > I did test that and it looked to be working ok Actually now I think about it a bit more, maybe it isn't The paths listed are to the temp maven build directory, which I guess is not correct (since it is 'temporary')? I suppose the paths are meant to resolve to the artifacts in the local m2 repository? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [camel-k] jamesnetherton commented on pull request #1931: Use Quarkus fast-jar package format apache/camel-k-runtime#360
jamesnetherton commented on pull request #1931: URL: https://github.com/apache/camel-k/pull/1931#issuecomment-764723809 > Will this work with local dependency resolution? It would be good to at least try it out with the set of local commands which use the current way of resolving dependencies. For example running `kamel inspect` and `kamel inspect --all-dependencies`. I did test that and it looked to be working ok. Also ran the 'local' integration test suite and it passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
