[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r403913242
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -290,3 +291,63 @@ section.frontpage h2 {
text-align: center;
}
}
+
+section.frontpage.camelProjects {
+ display: flex;
+ flex-wrap: wrap;
+}
+
+.platforms {
+ flex: 33%;
+ padding: 0.5rem 0;
+}
+
+.platforms div {
+ padding: 0.5rem;
+ margin: 0.5rem;
+ height: 100%;
+}
+
+.platforms img {
+ margin: 0 auto;
+ display: block;
+ width: 60%;
+}
+
+section.frontpage .platforms h2 {
+ text-align: center;
+ text-transform: capitalize;
+ width: 100%;
+ color: var(--heading-font-color);
+}
+
+section.frontpage .platforms p {
+ text-align: center;
+}
+
+.main-blk {
+ width: 500px;
+ height: 500px;
+ position: relative;
+}
+
+.half-circle {
+ position: absolute;
+ width: 250px;
+ top: 0;
+ right: 0;
+ overflow: hidden;
+}
+
+.half-circle img {
+ left: -250px;
+ position: relative;
+}
+
+.other-half-circle {
+ position: absolute;
+ width: 250px;
+ top: 0;
+ left: 0;
+ overflow: hidden;
+}
Review comment:
All these need to be scoped to `.frontpage .platforms`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r403913421
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -290,3 +291,63 @@ section.frontpage h2 {
text-align: center;
}
}
+
+section.frontpage.camelProjects {
+ display: flex;
+ flex-wrap: wrap;
+}
+
+.platforms {
+ flex: 33%;
+ padding: 0.5rem 0;
+}
+
+.platforms div {
+ padding: 0.5rem;
+ margin: 0.5rem;
+ height: 100%;
+}
+
+.platforms img {
+ margin: 0 auto;
+ display: block;
+ width: 60%;
+}
+
+section.frontpage .platforms h2 {
+ text-align: center;
+ text-transform: capitalize;
+ width: 100%;
+ color: var(--heading-font-color);
+}
+
+section.frontpage .platforms p {
+ text-align: center;
+}
+
+.main-blk {
+ width: 500px;
+ height: 500px;
+ position: relative;
+}
+
+.half-circle {
+ position: absolute;
+ width: 250px;
+ top: 0;
+ right: 0;
+ overflow: hidden;
+}
+
+.half-circle img {
+ left: -250px;
+ position: relative;
+}
+
+.other-half-circle {
+ position: absolute;
+ width: 250px;
+ top: 0;
+ left: 0;
+ overflow: hidden;
+}
Review comment:
I don't see this used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r403912704
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -290,3 +291,63 @@ section.frontpage h2 {
text-align: center;
}
}
+
+section.frontpage.camelProjects {
Review comment:
camelProjects -> platforms
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r402228852
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -290,3 +291,37 @@ section.frontpage h2 {
text-align: center;
}
}
+
+section.frontpage.camelProjects {
+ display: flex;
+ flex-wrap: wrap;
+}
+
+.projectDetails {
+ flex: 33%;
+ padding: 0.5rem 0;
+}
+
+.projectDetails div {
+ padding: 0.5rem;
+ margin: 0.5rem;
+ height: 100%;
+}
+
+.projectDetails img {
+ margin: 0 auto;
+ display: block;
+ width: 60%;
+}
+
+section.frontpage .projectDetails h2 {
+ text-align: center;
+ text-transform: capitalize;
+ width: 100%;
+ color: var(--heading-font-color);
+}
+
+section.frontpage .projectDetails p {
+ font-style: italic;
Review comment:
Remove italic
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r402227595
##
File path: content/_index.md
##
@@ -53,55 +53,67 @@ Camel supports around 50 data formats, allowing to
translate messages}}
-{{< section "frontpage projects" >}}
-{{< div "project" >}}
-# Camel
-
-**Apache Camel** is the *Swiss knife* of integration.
-
-Read the docs
-EIP
reference
-Component reference
-{{< /div >}}
-
-{{< div "project" >}}
-# Camel K
+{{< section "frontpage camelProjects" >}}
+# Apache Camel 3 - Projects
Review comment:
```suggestion
# Platforms Camel runs on
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r402228684
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -246,7 +246,8 @@ section.frontpage h2 {
}
@media screen and (max-width: 626px) {
- .split {
+ .split,
+ .projectDetails {
Review comment:
projectDetails -> platforms
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r399824699
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -237,6 +237,10 @@ section.frontpage h1 {
flex: 100%;
}
+ .box-new {
Review comment:
We have Apache Camel logo
[here](https://github.com/apache/camel/tree/master/docs/img) not sure how Claus
created that image in the tweet.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618968
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -273,3 +277,48 @@ section.frontpage h1 {
text-align: center;
}
}
+
+section.frontpage.projects-new {
+ display: flex;
+ display: -webkit-box;
+ display: -ms-flexbox;
+ flex-wrap: wrap;
+}
+
+.box-new {
+ -webkit-box-flex: 33%;
+ -ms-flex: 33%;
Review comment:
Remove browser prefixes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618447
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -237,6 +237,10 @@ section.frontpage h1 {
flex: 100%;
}
+ .box-new {
Review comment:
Can't we use the existing `box` class? Naming things `-new` leads to naming
the next new thing `-newer` and the thing after that one `-newest` and so on.
This is never a good practice. Read
[this](https://www.w3.org/QA/Tips/goodclassnames).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398619183
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -273,3 +277,48 @@ section.frontpage h1 {
text-align: center;
}
}
+
+section.frontpage.projects-new {
+ display: flex;
+ display: -webkit-box;
+ display: -ms-flexbox;
+ flex-wrap: wrap;
+}
+
+.box-new {
+ -webkit-box-flex: 33%;
+ -ms-flex: 33%;
+ flex: 33%;
+ padding: 0.5rem 0;
+}
+
+.box-new div {
+ padding: 0.5rem;
+ margin: 0.5rem;
+ height: 100%;
+}
+
+.box-new img {
+ margin: 0 auto;
+ display: block;
+}
+
+section.frontpage .box-new h2 {
+ text-align: center;
+ text-transform: capitalize;
+ width: 100%;
+ color: var(--color-black);
+}
+
+section.frontpage .box-new p {
+ font-style: italic;
+ text-align: center;
+}
+
+section.frontpage.projects .project h2 {
+ white-space: nowrap;
+ padding: 1rem 0;
+ -webkit-box-flex: 1;
+ -ms-flex: 1;
Review comment:
Remove browser prefixes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request #270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in
frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618822
##
File path: antora-ui-camel/src/css/frontpage.css
##
@@ -273,3 +277,48 @@ section.frontpage h1 {
text-align: center;
}
}
+
+section.frontpage.projects-new {
+ display: flex;
+ display: -webkit-box;
+ display: -ms-flexbox;
Review comment:
We don't add browser prefixes, we rely only on standards.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
