[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu URL: https://github.com/apache/camel-website/pull/195#issuecomment-604360393 @aashnajena the redirects are only used when the website is deployed to the Apache HTTP server, that file is not consulted when running via `yarn preview` as Hugo is acting as a web server in that case. This is the case also when we access the preview on our build server. I think the ones you have added in `.htaccess` should work. I don't think we need to escape the `#` character. But I'll test locally just to make sure. The way I test is a bit involved, I run the Apache HTTP server in a Linux container. One thing I'd like you to try is to see if we can use the default layout in this case. I think `layouts/_default/section.html` should apply here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu URL: https://github.com/apache/camel-website/pull/195#issuecomment-602570726 I need to test those `Redirect` rules, not sure if `#` will be interpreted as a comment. @aashnajena can you please squash these commits into single one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu URL: https://github.com/apache/camel-website/pull/195#issuecomment-598716899 @aashnajena I've added a suggestion that I hope helps clear things up. Remember that you can run checks locally via `yarn checks`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu
zregvart commented on issue #195: [CAMEL 14581] Re-organizing sub-menus under "Projects" tab on the main-menu URL: https://github.com/apache/camel-website/pull/195#issuecomment-597786957 Thanks! I like this, it's simpler and frees the "Projects" menu from sub-menus, an approach we could take for other navigation links on top. We run a link checker, and these issues were reported: ``` [2020-03-11T17:19:33.532Z] page not found from blog/GSoC-2020-announced/index.html to projects/camel-k/index.html [2020-03-11T17:19:33.532Z] page not found from blog/GSoC-2020-announced/index.html to projects/camel-quarkus/index.html [2020-03-11T17:19:33.532Z] page not found from blog/GSoC-2020-announced/index.html to projects/camel-kafka-connector/index.html [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../camel-k/latest/index.html [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../community/mailing-list/index.html [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../components/latest/index.html [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../camel-kafka-connector/latest/index.html [2020-03-11T17:19:33.532Z] page not found from projects/index.html to ../camel-quarkus/latest/index.html ``` If I recall correctly, we have Hugo configured so that in the generated content you can use absolute links, i.e. starting from `/` and they will be converted to relative links. Since this changes some of the URLs we usually also configure redirection, for example: https://github.com/apache/camel-website/blob/666bd34ea046eb5cd4b7b51001b5142382bb9239/static/.htaccess#L1051 I think it would be good to redirect from `/projects/camel-k/` to this unified `/projects/#Apache Camel K` (not sure about the anchor there). Also can you incorporate the changes from #188. You might need to rebase and move the changes manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
