Re: [PR] CAMEL-22938: Fix Map type mismatch in OpenTelemetrySpanAdapter [camel]

2026-02-02 Thread via GitHub 


davsclaus merged PR #21201:
URL: https://github.com/apache/camel/pull/21201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] CAMEL-22938: Fix Map type mismatch in OpenTelemetrySpanAdapter [camel]

2026-02-01 Thread via GitHub 


github-actions[bot] commented on PR #21201:
URL: https://github.com/apache/camel/pull/21201#issuecomment-3833463647

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions 
to run
   
   * You can use the command `/component-test (camel-)component-name1 
(camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and 
`test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache 
Camel committers](https://camel.apache.org/community/team/#committers) have 
access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before 
sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

[PR] CAMEL-22938: Fix Map type mismatch in OpenTelemetrySpanAdapter [camel]

2026-02-01 Thread via GitHub 


gnodet opened a new pull request, #21201:
URL: https://github.com/apache/camel/pull/21201

   ## Description
   
   This PR fixes CAMEL-22938 - a Map type mismatch issue in 
`OpenTelemetrySpanAdapter` that was reported by SonarCloud.
   
   ## Problem
   
   The deprecated `setTag(Tag key, ...)` methods were passing `Tag` enum 
objects directly to `TAG_MAP.getOrDefault()` instead of calling 
`key.getAttribute()` first. Since `TAG_MAP` is declared as `Map` and keyed by String values, the lookup would always fail and return 
the default value.
   
   ## Solution
   
   Changed lines 78 and 88 to call `key.getAttribute()` before the Map lookup:
   - Line 78: `TAG_MAP.getOrDefault(key, ...)` → 
`TAG_MAP.getOrDefault(key.getAttribute(), ...)`
   - Line 88: `TAG_MAP.getOrDefault(key, ...)` → 
`TAG_MAP.getOrDefault(key.getAttribute(), ...)`
   
   This ensures the Tag enum is converted to its String representation before 
the Map lookup, allowing proper mapping of tags to OpenTelemetry semantic 
attributes.
   
   ## Testing
   
   - ✅ Build successful: `mvn clean compile -pl components/camel-opentelemetry 
-am -Dquickly`
   - ✅ All tests pass: `mvn test -pl components/camel-opentelemetry` (23 tests, 
0 failures)
   
   ## Impact
   
   - Fixes the SonarCloud issue about Map with wrong type for key
   - Ensures proper mapping of deprecated Tag enum values to OpenTelemetry 
semantic attributes
   - Minimal change with no impact on non-deprecated methods
   - Since these methods are already deprecated, impact is limited to legacy 
code
   
   ## Related Issue
   
   https://issues.apache.org/jira/browse/CAMEL-22938
   
   ---
   Pull Request opened by [Augment Code](https://www.augmentcode.com/) with 
guidance from the PR author


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]