Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2829607930 okay fixed and merged in another commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
Croway commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2829615030 > okay fixed and merged in another commit Thanks a lot Claus. Can I close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus closed pull request #17862: Expose UncPath for backward compatibility URL: https://github.com/apache/camel/pull/17862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2829592506 okay I have a fix in the works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on code in PR #17862:
URL: https://github.com/apache/camel/pull/17862#discussion_r2059143466
##
components/camel-smb/src/main/java/org/apache/camel/component/smb/SmbConstants.java:
##
@@ -81,4 +81,5 @@ public class SmbConstants {
javaType = "org.apache.camel.component.file.GenericFileExist")
@Deprecated
public static final String SMB_FILE_EXISTS = "CamelSmbFileExists";
+public static final String SMB_UNC_PATH = "CamelSmbUncPath";
Review Comment:
This should also be annotated like the others so tooling would know about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2828724657 Maybe you can add some logging in that code to see what the CI server logs - its hard to reproduce this if it works locally but fails on ASF CI only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2828515755 yeah its strange -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
Croway commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2828141497 > [ERROR] org.apache.camel.component.smb.SmbComponentIT.testSmbRead -- Time elapsed: 2.028 s <<< FAILURE! java.lang.AssertionError: mock://result Expected 1 headers with key[CamelSmbUncPath], received 0 headers. Expected header values: [\localhost\data-rw\1.txt] at org.apache.camel.component.mock.MockEndpoint.fail(MockEndpoint.java:2015) at org.apache.camel.component.mock.MockEndpoint.assertTrue(MockEndpoint.java:1986) at org.apache.camel.component.mock.MockEndpoint.lambda$expectedHeaderValuesReceivedInAnyOrder$0(MockEndpoint.java:691) at org.apache.camel.component.mock.MockEndpoint.runTests(MockEndpoint.java:488) at org.apache.camel.component.mock.MockEndpoint.doAssertIsSatisfied(MockEndpoint.java:469) at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:431) at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:421) at org.apache.camel.component.smb.SmbComponentIT.testSmbRead(SmbComponentIT.java:53) at java.base/java.l ang.reflect.Method.invoke(Method.java:569) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) yeah, that is strange, locally is working, this line of code https://github.com/apache/camel/pull/17862/files#diff-c8ac41955f06eb913c93ab390020b89defda37d45def4e970d1fd9aeae4601d4R244 is supposed to add that header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2828116248 [ERROR] org.apache.camel.component.smb.SmbComponentIT.testSmbRead -- Time elapsed: 2.028 s <<< FAILURE! java.lang.AssertionError: mock://result Expected 1 headers with key[CamelSmbUncPath], received 0 headers. Expected header values: [\\localhost\data-rw\1.txt] at org.apache.camel.component.mock.MockEndpoint.fail(MockEndpoint.java:2015) at org.apache.camel.component.mock.MockEndpoint.assertTrue(MockEndpoint.java:1986) at org.apache.camel.component.mock.MockEndpoint.lambda$expectedHeaderValuesReceivedInAnyOrder$0(MockEndpoint.java:691) at org.apache.camel.component.mock.MockEndpoint.runTests(MockEndpoint.java:488) at org.apache.camel.component.mock.MockEndpoint.doAssertIsSatisfied(MockEndpoint.java:469) at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:431) at org.apache.camel.component.mock.MockEndpoint.assertIsSatisfied(MockEndpoint.java:421) at org.apache.camel.component.smb.SmbComponentIT.testSmbRead(SmbComponentIT.java:53) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
davsclaus commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2827479013 Can you do this in all the retrieveFile methods to set that header -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Expose UncPath for backward compatibility [camel]
Croway opened a new pull request, #17862: URL: https://github.com/apache/camel/pull/17862 The previous smb implementation was providing more information wrt the absolute path, for example, if camel-smb is connected to a share `localhost/data-rw`, and files are created under data-rw, a Camel consumer absolute path would be `/fileName` without data-rw, and there is no way to retrieve that information from the GenericFile, the previous implementation was handing smbj.File and that information was there. Does it make sense to add a header with that information? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Expose UncPath for backward compatibility [camel]
github-actions[bot] commented on PR #17862: URL: https://github.com/apache/camel/pull/17862#issuecomment-2827376255 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committers, please review the following items: * First-time contributors **require MANUAL approval** for the GitHub Actions to run * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot. * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR. * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. * :warning: Be careful when sharing logs. Review their contents before sharing them publicly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
