Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus merged PR #21644: URL: https://github.com/apache/camel/pull/21644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-4003389147 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on code in PR #21644:
URL: https://github.com/apache/camel/pull/21644#discussion_r2885726343
##
core/camel-core-model/src/main/java/org/apache/camel/model/dataformat/JacksonXML3DataFormat.java:
##
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.model.dataformat;
+
+import jakarta.xml.bind.annotation.XmlAccessType;
+import jakarta.xml.bind.annotation.XmlAccessorType;
+import jakarta.xml.bind.annotation.XmlAttribute;
+import jakarta.xml.bind.annotation.XmlRootElement;
+import jakarta.xml.bind.annotation.XmlTransient;
+
+import org.apache.camel.model.DataFormatDefinition;
+import org.apache.camel.spi.Metadata;
+
+/**
+ * Unmarshal an XML payloads to POJOs and back using XMLMapper extension of
Jackson 3.
+ */
+@Metadata(firstVersion = "4.18.0", label = "dataformat,transformation,xml",
title = "Jackson 3 XML")
+@XmlRootElement(name = "jacksonXml")
+@XmlAccessorType(XmlAccessType.FIELD)
+public class JacksonXML3DataFormat extends DataFormatDefinition implements
ContentTypeHeaderAware {
Review Comment:
This should be removed, as we already have the old dataformat to use where
we pick either jackson 2 or 3 at runtime. The DSL mode should not change (or
very very little)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3999056523 you can rebase main as there were some unmodified files that needed regen I dont dare do the regen on your behalf as this is a big PR and maybe something goes wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3998091762 yeah it may also even be on main branch itself -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
cunningt commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3998039605 Weird - I've built locally twice and have nothing uncommited.Rebased and trying again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644:
URL: https://github.com/apache/camel/pull/21644#issuecomment-3997964960
Run [[ -z $(git status --porcelain) ]] || { echo 'There are uncommitted
changes'; git status; echo; echo; git diff; exit 1; }
There are uncommitted changes
HEAD detached at pull/21644/merge
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified:
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/seda.json
modified:
catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/stub.json
modified:
dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/SedaEndpointBuilderFactory.java
modified:
dsl/camel-endpointdsl/src/generated/java/org/apache/camel/builder/endpoint/dsl/StubEndpointBuilderFactory.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3997234363 yeah it smells like a left over. You can also run the full regen script from the etc folder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
cunningt commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3997218651 I think I found it, `jacksonXml3` looks like it is left over from before the resolver changes, removing and testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
cunningt commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3997150806 @davsclaus Can you point me to the `Jackson3DataFormat `?I'm having trouble finding it locally - I think we need a org.apache.camel.component.jackson.JacksonDataFormat and a org.apache.camel.component.jackson3.JacksonDataFormat because of the com.fasterxml.* vs tools.jackson.* package name changes of imported classes (ObjectMapper in particular) but I'm not sure that's what we're talking about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3995878688 Great work Tom we are almost there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3995601700 I wonder if there is a reason why there is a new `Jackson3DataFormat` in the model classes of camel ? Ideally we can use the existing jackson data format model, and then the data format resolver will load jackson 3.x if its on the classpath (as you already have done). We have not added new exclusive options in the dataformat that are new in jackson 3.x only and not available in 2.x ? In other words if the DSL is unchanged or as little changed the better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3991332324 see `tooling/maven/camel-package-maven-plugin/pom.xml` this can maybe help you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3991323835 I think its some old stuff for the camel-archetype-api-component when its used for creating a new api based component, then there is something that creates a sample project and some groovy stuff verify -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
cunningt commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3990954330 I'm having some trouble figuring out the CI error here - is the error on "cat: target/it/HeaderSupport/build.log: No such file or directory"?I don't think I've changed anything in that area? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3982450631 I dont think we need need docs, lets try to make it a different JAR and nothing else. We know that jackson2 is eventually going to be dropped later when all the ducks are aligned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
cunningt commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3981610310 > And ditto for the `DefaultTransformerResolver` I think this is doable (and the DSL) but I think I'm going to need some help to prevent collisions between the generated docs between camel-jackson / camel-jackson3 - are there any other situations where two components have shared a DSL name or Transformer name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3976611202 I dont like we have duplicate DSLs. As an end user you would only use either Jackson 2 or 3 not both at the same time. So what we should look at is to make Camel attempt to load jackson3 if available and if not jackson2 and then keep the DSL as is. The DSL in Camel is big and verbose, we should avoid expanding this - especially because of a implementation detail of the jackson library upgraded under the hood. There is the DataFormatResolver that attempt to discover the library - that code can be improved to be able to detect jackson 3 and 2. See `DefaultDataFormatResolver` and its okay to add hardcoded code that says "jackson" then try "jackson3" first and if not found then fallback to as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] CAMEL-22857 Jackson 3 components : camel-jackson3, camel-jackson3-avro, camel-jackson3-protobuf, camel-jackson3xml [camel]
davsclaus commented on PR #21644: URL: https://github.com/apache/camel/pull/21644#issuecomment-3976611994 And ditto for the `DefaultTransformerResolver` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
