christophd merged PR #5419:
URL: https://github.com/apache/camel-k/pull/5419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
squakez commented on code in PR #5419:
URL: https://github.com/apache/camel-k/pull/5419#discussion_r1580833131
##
pkg/util/knative/knative.go:
##
@@ -75,7 +75,27 @@ func CreateSubscription(channelReference
corev1.ObjectReference, serviceName str
}
}
-func
christophd commented on code in PR #5419:
URL: https://github.com/apache/camel-k/pull/5419#discussion_r1580743874
##
pkg/trait/knative.go:
##
@@ -560,3 +571,19 @@ func (t *knativeTrait) extractServices(names []string,
serviceType knativeapi.Ca
sort.Strings(answer)
squakez commented on code in PR #5419:
URL: https://github.com/apache/camel-k/pull/5419#discussion_r1580698963
##
pkg/trait/knative.go:
##
@@ -486,9 +488,18 @@ func (t *knativeTrait) createTrigger(e *Environment, ref
*corev1.ObjectReference
if ref.Namespace ==
christophd commented on PR #5419:
URL: https://github.com/apache/camel-k/pull/5419#issuecomment-2078890768
@squakez issues are fixed now. also added some unit tests. ready for review,
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please
