Catalin Grigoroscuta created CASSANDRA-13895:
------------------------------------------------

             Summary: IOException unwrapping in CommitLogReader. 
readCommitLogSegment misses exceptions in resource creation block
                 Key: CASSANDRA-13895
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13895
             Project: Cassandra
          Issue Type: Bug
          Components: Core
            Reporter: Catalin Grigoroscuta
            Priority: Minor


CommitLogReader. readCommitLogSegment is unwrapping IOExceptions wrapped as 
RuntimeExceptions using a try-with-resource block.

However, the resource specification block, {{RandomAccessReader reader = 
RandomAccessReader.open(file)}}, could also throw such an exception, which is 
missed by the catch block and throws as a RuntimeException instead of an 
IOException. 

One such example that I've seen is: 
- RandomAccessReader.open (called in try-with-resource resource specification 
block initialization)
- ChannelProxy(File) constructor 
- ChannelProxy.openChannel (wraps IOException as RuntimeException) 

I don't know what the impact in Cassandra could be, I ran into this while 
processing CDC/commit logs for synchronization with another system.
Was using Cassandra 3.11.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to