[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379255#comment-17379255 ] Ekaterina Dimitrova edited comment on CASSANDRA-14162 at 7/12/21, 5:41 PM: --- As it is only sorted representation, probably it is fine but normally we don't backport new behaviors. I think that was the reason also to discuss initially whether this patch should be really backported at all. Cassandra has that behavior of having pain in the leg when you slap her in the face even after smallest changes, so I felt it's worth mentioning that change before any commit. Thank you both was (Author: e.dimitrova): As it is only sorted representation, probably it is fine but normally we don't backport new behaviors. I think that was the reason also to discuss initially whether this patch should be really backported at all. Cassandra has that behavior of having pain in the leg wen you slap her in the face even after smallest changes, so I felt it's worth mentioning that change before any commit. Thank you both > Backport 7950 (Output of nodetool compactionstats and compactionhistory does > not work well with long keyspace and column family names) > -- > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Tools >Reporter: Kurt Greaves >Assignee: Stefan Miklosovic >Priority: Low > Fix For: 3.0.25 > > Attachments: 14162-3.0.patch, Screenshot from 2018-01-11 > 01-02-02.png, Screenshot from 2018-01-11 01-02-46.png, Screenshot from > 2018-01-11 01-02-51.png > > > Colleagues have had issues with output of listsnapshots/compactionstats > because of things with really long names. Mostly cosmetic but I see no reason > we shouldn't backport CASSANDRA-7950 to 3.0. It's practically a bugfix. I've > attached a patch and a bunch of images to show the relevant commands working > as intended after applying the patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379255#comment-17379255 ] Ekaterina Dimitrova edited comment on CASSANDRA-14162 at 7/12/21, 4:36 PM: --- As it is only sorted representation, probably it is fine but normally we don't backport new behaviors. I think that was the reason also to discuss initially whether this patch should be really backported at all. Cassandra has that behavior of having pain in the leg wen you slap her in the face even after smallest changes, so I felt it's worth mentioning that change before any commit. Thank you both was (Author: e.dimitrova): As it is only sorted representation, probably it is fine but normally we don't backport new behaviors. I think that was the reason also to discuss initially whether this patch should be really backported at all. Cassandra has that behavior of having pain in the leg wen you slap her in the face even after smallest changes, so I felt worth mentioning that change before any commit. Thank you both > Backport 7950 (Output of nodetool compactionstats and compactionhistory does > not work well with long keyspace and column family names) > -- > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Tools >Reporter: Kurt Greaves >Assignee: Stefan Miklosovic >Priority: Low > Fix For: 3.0.25 > > Attachments: 14162-3.0.patch, Screenshot from 2018-01-11 > 01-02-02.png, Screenshot from 2018-01-11 01-02-46.png, Screenshot from > 2018-01-11 01-02-51.png > > > Colleagues have had issues with output of listsnapshots/compactionstats > because of things with really long names. Mostly cosmetic but I see no reason > we shouldn't backport CASSANDRA-7950 to 3.0. It's practically a bugfix. I've > attached a patch and a bunch of images to show the relevant commands working > as intended after applying the patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379255#comment-17379255 ] Ekaterina Dimitrova edited comment on CASSANDRA-14162 at 7/12/21, 4:36 PM: --- As it is only sorted representation, probably it is fine but normally we don't backport new behaviors. I think that was the reason also to discuss initially whether this patch should be really backported at all. Cassandra has that behavior of having pain in the leg wen you slap her in the face even after smallest changes, so I felt worth mentioning that change before any commit. Thank you both was (Author: e.dimitrova): As it is only sorted representation, probably it is fine but normally we don't backport new behaviors. I think that was the reason also to discuss initially whether this patch should be really backported at all. Cassandra has that behavior of having pain in the leg wen you slap her in the face, so I felt worth mentioning that change before any commit. Thank you both > Backport 7950 (Output of nodetool compactionstats and compactionhistory does > not work well with long keyspace and column family names) > -- > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Tools >Reporter: Kurt Greaves >Assignee: Stefan Miklosovic >Priority: Low > Fix For: 3.0.25 > > Attachments: 14162-3.0.patch, Screenshot from 2018-01-11 > 01-02-02.png, Screenshot from 2018-01-11 01-02-46.png, Screenshot from > 2018-01-11 01-02-51.png > > > Colleagues have had issues with output of listsnapshots/compactionstats > because of things with really long names. Mostly cosmetic but I see no reason > we shouldn't backport CASSANDRA-7950 to 3.0. It's practically a bugfix. I've > attached a patch and a bunch of images to show the relevant commands working > as intended after applying the patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378073#comment-17378073 ] Stefan Miklosovic edited comment on CASSANDRA-14162 at 7/9/21, 1:43 PM: The backport contains yet another "feature" which is sorting of the output. This sorting was firstly introduced in 3.2 in https://issues.apache.org/jira/browse/CASSANDRA-10464 and since then it is sorted one way or the other but together with [~e.dimitrova] (thanks for spotting this) we actually think that it should not be the part of the backport as that would be the introduction of behaviour which would not address the original issue this ticket is trying to solve. Unless we agree that we may introduce sorting (either doing it directly in this ticket or creating new one just for 3.0.25), we drift towards removing sorting to be strictly just about solving the long names. However, I doubt that the introduction of sorting would be "bad". It only improve the user experience and I can not see any reason why a user would be suddenly "confused and angry" that we started to sort it for him since 3.0.25. The commit which deletes sorting is here: https://github.com/apache/cassandra/pull/1103/commits/415a029657fe9a3873cdd256d43fe2e9ca8be384 was (Author: stefan.miklosovic): The backport contains yet another "feature" which is sorting of the output. This sorting was firstly introduced in 3.2 in https://issues.apache.org/jira/browse/CASSANDRA-10464 and since then it is sorted one way or the other but together with [~e.dimitrova] (thanks for spotting this) we actually think that it should not be the part of the backport as that would be the introduction of behaviour which would not address the original issue this ticket is trying to solve. Unless we agree that we may introduce sorting (either doing it directly in this ticket or creating new one just for 3.0.25), we drift towards removing sorting to be strictly just about solving the long names. However, I doubt that the introduction of sorting would be "bad". It only improve the user experience and I can not see any reason why a user would be suddenly "confused and angry" that we started to sort it for him since 3.0.25. > Backport 7950 (Output of nodetool compactionstats and compactionhistory does > not work well with long keyspace and column family names) > -- > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Tools >Reporter: Kurt Greaves >Assignee: Stefan Miklosovic >Priority: Low > Fix For: 3.0.25 > > Attachments: 14162-3.0.patch, Screenshot from 2018-01-11 > 01-02-02.png, Screenshot from 2018-01-11 01-02-46.png, Screenshot from > 2018-01-11 01-02-51.png > > > Colleagues have had issues with output of listsnapshots/compactionstats > because of things with really long names. Mostly cosmetic but I see no reason > we shouldn't backport CASSANDRA-7950 to 3.0. It's practically a bugfix. I've > attached a patch and a bunch of images to show the relevant commands working > as intended after applying the patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376804#comment-17376804 ] Stefan Miklosovic edited comment on CASSANDRA-14162 at 7/8/21, 7:35 AM: [~brandon.williams] would you mind to review please? [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6} cdd8fa30-df57-11eb-a591-43fc063264b7 systemlocal 2021-07-07T21:16:17.363 5378 5160 {4:1} cdcec100-df57-11eb-a591-43fc063264b7 systemsize_estimates 2021-07-07T21:16:17.296 4612836268 {1:4, 2:1, 3:1} cdaf5220-df57-11eb-a591-43fc063264b7 system_auth resource_role_permissons_index 2021-07-07T21:16:17.090 611 304 {1:4, 2:4, 3:3} cd9672f0-df57-11eb-a591-43fc063264b7 system_auth role_permissions 2021-07-07T21:16:16.927 1013 522 {1:1, 4:1} cbe3b9e0-df57-11eb-a591-43fc063264b7 system_schema views 2021-07-07T21:16:14.078 153 99{1:3, 2:1} [21:49:44 ~]$ docker-shell-master-nodetool listsnapshots Snapshot Details: Snapshot name Keyspace name Column family name True size Size on disk 1625686746556 system_distributed parent_repair_history 0 bytes 13 bytes 1625686746556 system_distributed repair_history 0 bytes 13 bytes 1625686746556 keyspace1 counter1 0 bytes 847 bytes 1625686746556 keyspace1 standard1 1.5 GB2.31 GB 1625686746556 test test 0 bytes 872 bytes 1625686746556 system_authroles 0 bytes 5.14 KB 1625686746556 system_authrole_members 0 bytes 13 bytes 1625686746556 system_authresource_role_permissons_index 0 bytes 15.6 KB 1625686746556 system_authrole_permissions 0 bytes 15.75 KB 1625686746556 system_traces sessions 0 bytes 13 bytes 1625686746556 system_traces events 0 bytes 13 bytes Total TrueDiskSpaceUsed: 1.5 GB {code} was (Author: stefan.miklosovic): [~brandon.williams] would you mind to review please? [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376804#comment-17376804 ] Stefan Miklosovic edited comment on CASSANDRA-14162 at 7/7/21, 7:50 PM: [~brandon.williams] would you mind to review please? [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6} cdd8fa30-df57-11eb-a591-43fc063264b7 systemlocal 2021-07-07T21:16:17.363 5378 5160 {4:1} cdcec100-df57-11eb-a591-43fc063264b7 systemsize_estimates 2021-07-07T21:16:17.296 4612836268 {1:4, 2:1, 3:1} cdaf5220-df57-11eb-a591-43fc063264b7 system_auth resource_role_permissons_index 2021-07-07T21:16:17.090 611 304 {1:4, 2:4, 3:3} cd9672f0-df57-11eb-a591-43fc063264b7 system_auth role_permissions 2021-07-07T21:16:16.927 1013 522 {1:1, 4:1} cbe3b9e0-df57-11eb-a591-43fc063264b7 system_schema views 2021-07-07T21:16:14.078 153 99{1:3, 2:1} [21:49:44 ~]$ docker-shell-master-nodetool listsnapshots Snapshot Details: Snapshot name Keyspace name Column family name True size Size on disk 1625686746556 system_distributed parent_repair_history 0 bytes 13 bytes 1625686746556 system_distributed repair_history 0 bytes 13 bytes 1625686746556 keyspace1 counter1 0 bytes 847 bytes 1625686746556 keyspace1 standard1 1.5 GB2.31 GB 1625686746556 test test 0 bytes 872 bytes 1625686746556 system_authroles 0 bytes 5.14 KB 1625686746556 system_authrole_members 0 bytes 13 bytes 1625686746556 system_authresource_role_permissons_index 0 bytes 15.6 KB 1625686746556 system_authrole_permissions 0 bytes 15.75 KB 1625686746556 system_traces sessions 0 bytes 13 bytes 1625686746556 system_traces events 0 bytes 13 bytesTotal TrueDiskSpaceUsed: 1.5 GB {code} was (Author: stefan.miklosovic): [~brandon.williams] would you mind to review please? [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6}
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376804#comment-17376804 ] Stefan Miklosovic edited comment on CASSANDRA-14162 at 7/7/21, 7:36 PM: [~brandon.williams] would you mind to review please? [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6} cdd8fa30-df57-11eb-a591-43fc063264b7 systemlocal 2021-07-07T21:16:17.363 5378 5160 {4:1} cdcec100-df57-11eb-a591-43fc063264b7 systemsize_estimates 2021-07-07T21:16:17.296 4612836268 {1:4, 2:1, 3:1} cdaf5220-df57-11eb-a591-43fc063264b7 system_auth resource_role_permissons_index 2021-07-07T21:16:17.090 611 304 {1:4, 2:4, 3:3} cd9672f0-df57-11eb-a591-43fc063264b7 system_auth role_permissions 2021-07-07T21:16:16.927 1013 522 {1:1, 4:1} cbe3b9e0-df57-11eb-a591-43fc063264b7 system_schema views 2021-07-07T21:16:14.078 153 99{1:3, 2:1} {code} was (Author: stefan.miklosovic): PR [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6} cdd8fa30-df57-11eb-a591-43fc063264b7 systemlocal 2021-07-07T21:16:17.363 5378 5160 {4:1} cdcec100-df57-11eb-a591-43fc063264b7 systemsize_estimates 2021-07-07T21:16:17.296 4612836268 {1:4, 2:1, 3:1} cdaf5220-df57-11eb-a591-43fc063264b7 system_auth resource_role_permissons_index 2021-07-07T21:16:17.090 611 304 {1:4, 2:4, 3:3} cd9672f0-df57-11eb-a591-43fc063264b7 system_auth role_permissions 2021-07-07T21:16:16.927 1013 522 {1:1, 4:1} cbe3b9e0-df57-11eb-a591-43fc063264b7 system_schema views 2021-07-07T21:16:14.078 153 99{1:3, 2:1} {code} > Backport 7950 (Output of nodetool compactionstats and compactionhistory does > not work well with long keyspace and column family names) > -- > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug > Components: Leg
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950 (Output of nodetool compactionstats and compactionhistory does not work well with long keyspace and column family names)
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376804#comment-17376804 ] Stefan Miklosovic edited comment on CASSANDRA-14162 at 7/7/21, 7:32 PM: PR [https://github.com/apache/cassandra/pull/1103/files] {code:java} [21:28:09 ~]$ docker-shell-master-nodetool compactionstats -H pending tasks: 3 id compaction type keyspace table completed total unit progress 54a026b0-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 244.39 MB 709.18 MB bytes 34.46% 1b9c5b40-df58-11eb-a591-43fc063264b7 Compaction keyspace1 standard1 340.16 MB 710.4 MB bytes 47.88% Active compaction remaining time : 0h13m55s [21:28:12 ~]$ docker-shell-master-nodetool compactionhistory Compaction History: id keyspace_name columnfamily_name compacted_atbytes_in bytes_out rows_merged dddae0b0-df57-11eb-a591-43fc063264b7 system_schema tables 2021-07-07T21:16:44.219 3396 2716 {1:7, 4:1} ddd0a780-df57-11eb-a591-43fc063264b7 system_schema columns 2021-07-07T21:16:44.152 6300 5798 {1:7, 4:1} dd206a50-df57-11eb-a591-43fc063264b7 system_schema keyspaces 2021-07-07T21:16:42.997 669 381 {1:7, 4:1} ce15b510-df57-11eb-a591-43fc063264b7 systemsstable_activity 2021-07-07T21:16:17.761 1492 354 {1:62, 2:6} cdd8fa30-df57-11eb-a591-43fc063264b7 systemlocal 2021-07-07T21:16:17.363 5378 5160 {4:1} cdcec100-df57-11eb-a591-43fc063264b7 systemsize_estimates 2021-07-07T21:16:17.296 4612836268 {1:4, 2:1, 3:1} cdaf5220-df57-11eb-a591-43fc063264b7 system_auth resource_role_permissons_index 2021-07-07T21:16:17.090 611 304 {1:4, 2:4, 3:3} cd9672f0-df57-11eb-a591-43fc063264b7 system_auth role_permissions 2021-07-07T21:16:16.927 1013 522 {1:1, 4:1} cbe3b9e0-df57-11eb-a591-43fc063264b7 system_schema views 2021-07-07T21:16:14.078 153 99{1:3, 2:1} {code} was (Author: stefan.miklosovic): [https://github.com/apache/cassandra/pull/1103/files] > Backport 7950 (Output of nodetool compactionstats and compactionhistory does > not work well with long keyspace and column family names) > -- > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Tools >Reporter: Kurt Greaves >Assignee: Stefan Miklosovic >Priority: Low > Fix For: 3.0.x > > Attachments: 14162-3.0.patch, Screenshot from 2018-01-11 > 01-02-02.png, Screenshot from 2018-01-11 01-02-46.png, Screenshot from > 2018-01-11 01-02-51.png > > > Colleagues have had issues with output of listsnapshots/compactionstats > because of things with really long names. Mostly cosmetic but I see no reason > we shouldn't backport CASSANDRA-7950 to 3.0. It's practically a bugfix. I've > attached a patch and a bunch of images to show the relevant commands working > as intended after applying the patch. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-14162) Backport 7950
[ https://issues.apache.org/jira/browse/CASSANDRA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398102#comment-16398102 ] Kurt Greaves edited comment on CASSANDRA-14162 at 3/14/18 4:53 AM: --- Anyone feel like reviewing this? I put it in a GH branch for easier reviewing. [3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...kgreav:14162-3.0] was (Author: kurtg): Anyone feel like reviewing this? I put it in a GH branch for easier reviewing. [3.0|https://github.com/apache/cassandra/compare/cassandra-3.11...kgreav:14162-3.0] > Backport 7950 > - > > Key: CASSANDRA-14162 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14162 > Project: Cassandra > Issue Type: Bug >Reporter: Kurt Greaves >Assignee: Kurt Greaves >Priority: Minor > Fix For: 3.0.x > > Attachments: 14162-3.0.patch, Screenshot from 2018-01-11 > 01-02-02.png, Screenshot from 2018-01-11 01-02-46.png, Screenshot from > 2018-01-11 01-02-51.png > > > Colleagues have had issues with output of listsnapshots/compactionstats > because of things with really long names. Mostly cosmetic but I see no reason > we shouldn't backport CASSANDRA-7950 to 3.0. It's practically a bugfix. I've > attached a patch and a bunch of images to show the relevant commands working > as intended after applying the patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org