[jira] [Comment Edited] (CASSANDRA-14633) Update trunk's netty to 4.1.128

2018-08-09 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575743#comment-16575743
 ] 

Dinesh Joshi edited comment on CASSANDRA-14633 at 8/10/18 4:19 AM:
---

+1

I scanned through the release notes for Netty between version 4.1.15 to 4.1.28 
and I did not see anything obvious that would break us. For posterity's sake, I 
am pasting the release notes in reverse chronological order as an easy 
reference -
{noformat}
Netty 4.1.28.Final released

Today we announce the release of netty 4.1.28.Final. This release contains 
bugfixes and add support to use any supported SocketOption by the JDK. Please 
upgrade once you have the chance.

The most important changes are:

Support the usage of SocketOption when nio is used and the java version >= 7 
(#8085)
Leak detection combined with composite buffers results in incorrectly handled 
writerIndex when calling ByteBufUtil.writeAscii/writeUtf8 (#8153)
Allow to validate sni hostname with underscore (#8150)
HTTP/2 child channel read cycle doesn't respect RecvByteBufAllocator and may 
drop data if stream closed while auto read is off (#8147)

Netty 4.1.27.Final released

Due some possible regression that could cause an NPE during selecting the 
keymaterial if the alias is not known when using OpenSSL (and so signal back 
the wrong alert to the remote peer) we decided to cut another netty releases. 
While it was possible to "work around" this regression by using a 
KeyManagerFactory to configure SslContextBuilder we thought this deserves a 
fast release.

Beside fixing the above mentioned bug we also fixes a few other small things.

Netty 4.1.26.Final released

I'm happy to announce the latest release of the 4.1 series after almost 2 month 
of hard work.

These release contains bug-fixes, performance enhancements and feature so we 
encourage everyone to upgrade.

The most important changes are:

Add OpenSslX509KeyManagerFactory which makes it even easier for people get the 
maximum performance when using OpenSSL / LibreSSL / BoringSSL with netty (#8084)
Do not log explicit no unsafe, fixes helper method (#8111)
Fix support for shading native libraries which was broken (#8091)
Remove usage of ObjectCleaner (#8064)
Reorder channel state changes in Http2MultiplexCodec child channel (#8070)
Remove id from DnsQueryContextManager whenever the promise is fullfilled (#8058)
HpackDecoder treats invalid pseudo-headers as stream level errors (#8046)
Allow to cache keymaterial when using OpenSSL (#8036)
Epoll and Kqueue shouldn't read by default (#8024)
Defer channelInactive and channelUnregistered events in Http2MultiplexCodec 
(#8021)
Provide an API for controlling and h2c upgrade response stream in 
Http2MultiplexCodec (#7968)
Fix CharSequenceValueConverter.convertToByte implementation for AsciiString 
(#7994)
Set (and override) websocket handshake headers after custom headers (#7975)
Allow to schedule tasks up to Long.MAX_VALUE (#7972)
Correctly let Http2UnkownFrame extend HttpStreamFrame (#7976)
Read until all data is consumed when EOF is detected (#7961)
Propagate pong frames in WebSocketProtocolHandler (#7955)
Remove HpackDecoder.maxHeaderListSizeGoAway (#7911)
Guard against calling malloc(0) when create ByteBuffer (#7948)
Correctly clear the error stack in all cases when using 
ReferenceCountedOpenSslEngine (#7941)
Correctly copy existing elements when CodecOutputList.add(index, element) is 
used (#7931)


Netty 4.1.25.Final released

I'm happy to announce the latest release of the 4.1 series.

These releases contains bug-fixes, performance enhancements and feature so we 
encourage everyone to upgrade.

The most important changes are:

Always follow cnames even if a matching A or  record was found. (#7919)
DefaultDnsCache should store more then one Entry per hostname. (#7906)
Allow to disable native transport and native ssl support via system property. 
(#7903)
Add null-check to Htt2FrameCodec#consumeBytes. (#7899)
Fix IllegalReferenceCountException when using Http2MultiplexCodec and a 
DefaultHttp2GoAwayFrame with a non empty ByteBuffer is received. (#7894)
Correctly handle responses with status 205 and payload. (#7891)
Respect MAX_MESSAGES_PER_READ in LocalChannel / LocalServerChannel. (#7885)
Implement isWritable and ensureWritable on ReadOnlyByteBufferBuf. (#7883)
Update DatagramPacket.recipient() to return the actual destination IP. (#7879)
Set the correct stream header state for h2c upgrades. (#7848)

Netty 4.1.24.Final released

These releases contains bug-fixes, performance enhancements and feature so we 
encourage everyone to upgrade. Importantly it also fixes a regression of 
4.1.23.Final which could lead to have resources not cleaned up correctly in 
some cases.

The most important changes are:

Fix eternal loop in Recycler.WeakOrderQueue.Head#run() that blocks 
ObjectCleaner thread (#7878)
Filter DNS results so they only 

[jira] [Comment Edited] (CASSANDRA-14633) Update trunk's netty to 4.1.128

2018-08-09 Thread Dinesh Joshi (JIRA)


[ 
https://issues.apache.org/jira/browse/CASSANDRA-14633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575743#comment-16575743
 ] 

Dinesh Joshi edited comment on CASSANDRA-14633 at 8/10/18 4:19 AM:
---

+1

I scanned through the release notes for Netty between version 4.1.15 and 4.1.28 
and I did not see anything obvious that would break us. For posterity's sake, I 
am pasting the release notes in reverse chronological order as an easy 
reference -
{noformat}
Netty 4.1.28.Final released

Today we announce the release of netty 4.1.28.Final. This release contains 
bugfixes and add support to use any supported SocketOption by the JDK. Please 
upgrade once you have the chance.

The most important changes are:

Support the usage of SocketOption when nio is used and the java version >= 7 
(#8085)
Leak detection combined with composite buffers results in incorrectly handled 
writerIndex when calling ByteBufUtil.writeAscii/writeUtf8 (#8153)
Allow to validate sni hostname with underscore (#8150)
HTTP/2 child channel read cycle doesn't respect RecvByteBufAllocator and may 
drop data if stream closed while auto read is off (#8147)

Netty 4.1.27.Final released

Due some possible regression that could cause an NPE during selecting the 
keymaterial if the alias is not known when using OpenSSL (and so signal back 
the wrong alert to the remote peer) we decided to cut another netty releases. 
While it was possible to "work around" this regression by using a 
KeyManagerFactory to configure SslContextBuilder we thought this deserves a 
fast release.

Beside fixing the above mentioned bug we also fixes a few other small things.

Netty 4.1.26.Final released

I'm happy to announce the latest release of the 4.1 series after almost 2 month 
of hard work.

These release contains bug-fixes, performance enhancements and feature so we 
encourage everyone to upgrade.

The most important changes are:

Add OpenSslX509KeyManagerFactory which makes it even easier for people get the 
maximum performance when using OpenSSL / LibreSSL / BoringSSL with netty (#8084)
Do not log explicit no unsafe, fixes helper method (#8111)
Fix support for shading native libraries which was broken (#8091)
Remove usage of ObjectCleaner (#8064)
Reorder channel state changes in Http2MultiplexCodec child channel (#8070)
Remove id from DnsQueryContextManager whenever the promise is fullfilled (#8058)
HpackDecoder treats invalid pseudo-headers as stream level errors (#8046)
Allow to cache keymaterial when using OpenSSL (#8036)
Epoll and Kqueue shouldn't read by default (#8024)
Defer channelInactive and channelUnregistered events in Http2MultiplexCodec 
(#8021)
Provide an API for controlling and h2c upgrade response stream in 
Http2MultiplexCodec (#7968)
Fix CharSequenceValueConverter.convertToByte implementation for AsciiString 
(#7994)
Set (and override) websocket handshake headers after custom headers (#7975)
Allow to schedule tasks up to Long.MAX_VALUE (#7972)
Correctly let Http2UnkownFrame extend HttpStreamFrame (#7976)
Read until all data is consumed when EOF is detected (#7961)
Propagate pong frames in WebSocketProtocolHandler (#7955)
Remove HpackDecoder.maxHeaderListSizeGoAway (#7911)
Guard against calling malloc(0) when create ByteBuffer (#7948)
Correctly clear the error stack in all cases when using 
ReferenceCountedOpenSslEngine (#7941)
Correctly copy existing elements when CodecOutputList.add(index, element) is 
used (#7931)


Netty 4.1.25.Final released

I'm happy to announce the latest release of the 4.1 series.

These releases contains bug-fixes, performance enhancements and feature so we 
encourage everyone to upgrade.

The most important changes are:

Always follow cnames even if a matching A or  record was found. (#7919)
DefaultDnsCache should store more then one Entry per hostname. (#7906)
Allow to disable native transport and native ssl support via system property. 
(#7903)
Add null-check to Htt2FrameCodec#consumeBytes. (#7899)
Fix IllegalReferenceCountException when using Http2MultiplexCodec and a 
DefaultHttp2GoAwayFrame with a non empty ByteBuffer is received. (#7894)
Correctly handle responses with status 205 and payload. (#7891)
Respect MAX_MESSAGES_PER_READ in LocalChannel / LocalServerChannel. (#7885)
Implement isWritable and ensureWritable on ReadOnlyByteBufferBuf. (#7883)
Update DatagramPacket.recipient() to return the actual destination IP. (#7879)
Set the correct stream header state for h2c upgrades. (#7848)

Netty 4.1.24.Final released

These releases contains bug-fixes, performance enhancements and feature so we 
encourage everyone to upgrade. Importantly it also fixes a regression of 
4.1.23.Final which could lead to have resources not cleaned up correctly in 
some cases.

The most important changes are:

Fix eternal loop in Recycler.WeakOrderQueue.Head#run() that blocks 
ObjectCleaner thread (#7878)
Filter DNS results so they only