[jira] [Comment Edited] (CASSANDRA-17027) Allow to grant permission for all tables in a keyspace
[
https://issues.apache.org/jira/browse/CASSANDRA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430577#comment-17430577
]
Andres de la Peña edited comment on CASSANDRA-17027 at 10/19/21, 2:25 PM:
--
Changes look good to me, +1. Here are CI runs including 100 repetitions of the
new {{GrantAndRevokeTest}}:
*
[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1075/workflows/68e62784-acb6-4ecd-b32b-9e01f4bf149b]
*
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1075/workflows/94c7d37d-4d76-47b9-b272-2f90f6c55348]
was (Author: adelapena):
Changes look good to me, +1. Here are CI runs for including 100 repetitions of
new test:
*
[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1075/workflows/68e62784-acb6-4ecd-b32b-9e01f4bf149b]
*
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1075/workflows/94c7d37d-4d76-47b9-b272-2f90f6c55348]
> Allow to grant permission for all tables in a keyspace
> ---
>
> Key: CASSANDRA-17027
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17027
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax, Feature/Authorization
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In some scenario it is useful to prevent users to alter or drop a keyspace
> while allowing them to create new tables and user types.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17027) Allow to grant permission for all tables in a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429289#comment-17429289 ] Ekaterina Dimitrova edited comment on CASSANDRA-17027 at 10/15/21, 1:43 PM: I think what was suggested makes sense and I am all in. Whether it should be in this ticket or not, I don't have strong preference in general as soon as we keep the CQLTester improvements in a separate commit from the main body of work in this ticket. On the other hand, if there are a few tickets working in that area it might be a good idea to keep the things incremental and push things one by one, not blocking anything. We can actually even push one commit as phase 1 and continue working on the other commit as part of phase 2 in the same ticket. I will leave this to you to decide how you want to organize the flow, just giving ideas. :) Otherwise, the suggestions make total sense to me. was (Author: e.dimitrova): I think what was suggested makes sense and I am all in. Whether it should be in this ticket or not, I don't have strong preference in general as soon as we keep the CQLTester improvements in a separate commit from the main body of work in this ticket. On the other hand, if there are a few tickets working in that area it might be a good idea to keep the things incremental and push things one by one, not blocking anything. We can actually even push one commit as phase 1 and continue working on the other commit as part of phase 2 in the same ticket. I will leave this to you to decide how you want to organize the flow. Otherwise, the suggestions make total sense to me. > Allow to grant permission for all tables in a keyspace > --- > > Key: CASSANDRA-17027 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17027 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/Authorization >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In some scenario it is useful to prevent users to alter or drop a keyspace > while allowing them to create new tables and user types. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17027) Allow to grant permission for all tables in a keyspace
[ https://issues.apache.org/jira/browse/CASSANDRA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429289#comment-17429289 ] Ekaterina Dimitrova edited comment on CASSANDRA-17027 at 10/15/21, 1:42 PM: I think what was suggested makes sense and I am all in. Whether it should be in this ticket or not, I don't have strong preference in general as soon as we keep the CQLTester improvements in a separate commit from the main body of work in this ticket. On the other hand, if there are a few tickets working in that area it might be a good idea to keep the things incremental and push things one by one, not blocking anything. We can actually even push one commit as phase 1 and continue working on the other commit as part of phase 2 in the same ticket. I will leave this to you to decide how you want to organize the flow. Otherwise, the suggestions make total sense to me. was (Author: e.dimitrova): I think what was suggested makes sense and I am all in. Whether it should be in this ticket or not, I don't have strong preference in general as soon as we keep the CQLTester improvements in a separate commit from the main body of work in this ticket. On the other hand, if there are a few tickets working in that area it might be a good idea to keep the things incremental and push things one by one. We can actually even push one commit as phase 1 and continue working on the other commit as part of phase 2 in the same ticket. I will leave this to you to decide how you want to organize the flow. Otherwise, the suggestions make total sense to me. > Allow to grant permission for all tables in a keyspace > --- > > Key: CASSANDRA-17027 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17027 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Syntax, Feature/Authorization >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In some scenario it is useful to prevent users to alter or drop a keyspace > while allowing them to create new tables and user types. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-17027) Allow to grant permission for all tables in a keyspace
[
https://issues.apache.org/jira/browse/CASSANDRA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428989#comment-17428989
]
Andres de la Peña edited comment on CASSANDRA-17027 at 10/14/21, 7:24 PM:
--
Using {{KEYSPACE_PER_TEST}} makes the test a bit awkward because we can't use
the table placeholders provided by {{CQTester}}, so we have a lot of usages of
{{KEYSPACE_PER_TEST}} and {{formatQuery}}. Nothing wrong with that, but I was
thinking that we could add a new
[{{CQLTester#useKeyspacePerTest()}}|https://github.com/adelapena/cassandra/blob/f8086df448c1253d0c08cef0e5cf86b234379c2d/test/unit/org/apache/cassandra/cql3/CQLTester.java#L694-L697]
method to make it use {{KEYSPACE_PER_TEST}} in {{formatQuery}},
{{createTable}}, etc. That way we can improve the readability of the new test,
and also make some minor cosmetic improvements in other tests using
{{KEYSPACE_PER_TEST}}.
I gave it a quick try
[here|https://github.com/adelapena/cassandra/commit/f8086df448c1253d0c08cef0e5cf86b234379c2d],
and IMO it simplifies things a bit. If you like it we can either incorporate
it here or in a separate ticket, wdyt?
was (Author: adelapena):
Using {{KEYSPACE_PER_TEST}} makes the test a bit awkward because we can't use
the table placeholders provided by {{CQTester}}, so we have a lot of usages of
{{KEYSPACE_PER_TEST}} and {{formatQuery}}. Nothing wrong with that, but I was
thinking that we could add a new {{CQLTester#useKeyspacePerTest()}} method to
make it use {{KEYSPACE_PER_TEST}} in {{formatQuery}}, {{createTable}}, etc.
That way we can improve the readability of the new test, and also make some
minor cosmetic improvements in other tests using {{KEYSPACE_PER_TEST}}.
I gave it a quick try
[here|https://github.com/adelapena/cassandra/commit/f8086df448c1253d0c08cef0e5cf86b234379c2d],
and IMO it simplifies things a bit. If you like it we can either incorporate
it here or in a separate ticket, wdyt?
> Allow to grant permission for all tables in a keyspace
> ---
>
> Key: CASSANDRA-17027
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17027
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax, Feature/Authorization
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In some scenario it is useful to prevent users to alter or drop a keyspace
> while allowing them to create new tables and user types.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
