[jira] [Comment Edited] (CASSANDRA-18753) Add an optimized default configuration to tests and make it available for new users
[
https://issues.apache.org/jira/browse/CASSANDRA-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829289#comment-17829289
]
Ekaterina Dimitrova edited comment on CASSANDRA-18753 at 3/20/24 7:54 PM:
--
{quote}The fault is from this ticket, so leaving it open is my preference (so
to maintain focus on the breakage, which is serious, but forgivable considering
agents are regularly hanging/thrashing atm).
{quote}
Agreed, I did not mean to suggest to close it before all outstanding issues are
fixed (here or in another blocker ticket). Just clarifying the status.
{quote}18594 solves it. It is only waiting on other small final changes in the
patch, eta is this week.
{quote}
Marking then 18594 as a blocker here, for clarity. Thanks!
was (Author: e.dimitrova):
{quote}The fault is from this ticket, so leaving it open is my preference (so
to maintain focus on the breakage, which is serious, but forgivable considering
agents are regularly hanging/thrashing atm).
{quote}
Agreed, I did not mean to suggest to close it before all outstanding issues are
fixed (here or in another blocker ticket). Just clarifying the status.
{quote}18594 solves it. It is only waiting on other small final changes in the
patch, eta is this week.
{quote}
Marking them 18594 as a blocker here, for clarity. Thanks!
> Add an optimized default configuration to tests and make it available for new
> users
> ---
>
> Key: CASSANDRA-18753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18753
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Urgent
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> CCM_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch,
>
> DTEST_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch
>
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> We currently offer only one sample configuration file with Cassandra, and
> that file is deliberately configured to disable all new functionality and
> incompatible improvements. This works well for legacy users that want to have
> a painless upgrade, but is a very bad choice for new users, or anyone wanting
> to make comparisons between Cassandra versions or between Cassandra and other
> databases.
> We offer very little indication, in the database packaging itself, that there
> are well-tested configuration choices that can solve known problems and
> dramatically improve performance. This is guaranteed to paint the database in
> a worse light than it deserves, and will very likely hurt adoption.
> We should find a way to offer a very easy way of choosing between "optimized"
> and "compatible" defaults. At minimal, we could provide alternate yaml files.
> Alternatively, we could build on the {{storage_compatibility_mode}} concept
> to grow it into a setting that not only enables/disables certain settings,
> but also changes their default values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18753) Add an optimized default configuration to tests and make it available for new users
[
https://issues.apache.org/jira/browse/CASSANDRA-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829289#comment-17829289
]
Ekaterina Dimitrova edited comment on CASSANDRA-18753 at 3/20/24 7:53 PM:
--
{quote}The fault is from this ticket, so leaving it open is my preference (so
to maintain focus on the breakage, which is serious, but forgivable considering
agents are regularly hanging/thrashing atm).
{quote}
Agreed, I did not mean to suggest to close it before all outstanding issues are
fixed (here or in another blocker ticket). Just clarifying the status.
{quote}18594 solves it. It is only waiting on other small final changes in the
patch, eta is this week.
{quote}
Marking them 18594 as a blocker here, for clarity. Thanks!
was (Author: e.dimitrova):
{quote}The fault is from this ticket, so leaving it open is my preference (so
to maintain focus on the breakage, which is serious, but forgivable considering
agents are regularly hanging/thrashing atm).
{quote}
Agreed, I did not mean to suggest to close it before all outstanding issues are
fixed (here or in another blocker ticket).
{quote}18594 solves it. It is only waiting on other small final changes in the
patch, eta is this week.
{quote}
Marking them 18594 as a blocker here, for clarity. Thanks!
> Add an optimized default configuration to tests and make it available for new
> users
> ---
>
> Key: CASSANDRA-18753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18753
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Urgent
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> CCM_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch,
>
> DTEST_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch
>
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> We currently offer only one sample configuration file with Cassandra, and
> that file is deliberately configured to disable all new functionality and
> incompatible improvements. This works well for legacy users that want to have
> a painless upgrade, but is a very bad choice for new users, or anyone wanting
> to make comparisons between Cassandra versions or between Cassandra and other
> databases.
> We offer very little indication, in the database packaging itself, that there
> are well-tested configuration choices that can solve known problems and
> dramatically improve performance. This is guaranteed to paint the database in
> a worse light than it deserves, and will very likely hurt adoption.
> We should find a way to offer a very easy way of choosing between "optimized"
> and "compatible" defaults. At minimal, we could provide alternate yaml files.
> Alternatively, we could build on the {{storage_compatibility_mode}} concept
> to grow it into a setting that not only enables/disables certain settings,
> but also changes their default values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18753) Add an optimized default configuration to tests and make it available for new users
[
https://issues.apache.org/jira/browse/CASSANDRA-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823946#comment-17823946
]
Branimir Lambov edited comment on CASSANDRA-18753 at 3/6/24 10:07 AM:
--
Well, tests [look much better
now|https://app.circleci.com/pipelines/github/blambov/cassandra/605/workflows/f567db7c-2231-4c22-8a60-7e43887880d7].
We have only one failure,
{{replica_side_filtering_test.TestSecondaryIndexes:test_complementary_deletion_with_limit_on_partition_key_column_with_empty_partitions}}
with SAI. Opened CASSANDRA-19459 for this, and proceeding to merge this ticket.
was (Author: blambov):
Well, tests [look much better
now|https://app.circleci.com/pipelines/github/blambov/cassandra/605/workflows/f567db7c-2231-4c22-8a60-7e43887880d7].
We have only one failure,
{{replica_side_filtering_test.TestSecondaryIndexes:test_complementary_deletion_with_limit_on_partition_key_column_with_empty_partitions}}
with SAI. Opened CASSANDRA- 19459 for this, and proceeding to merge this
ticket.
> Add an optimized default configuration to tests and make it available for new
> users
> ---
>
> Key: CASSANDRA-18753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18753
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Urgent
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> CCM_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch,
>
> DTEST_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch
>
> Time Spent: 11h
> Remaining Estimate: 0h
>
> We currently offer only one sample configuration file with Cassandra, and
> that file is deliberately configured to disable all new functionality and
> incompatible improvements. This works well for legacy users that want to have
> a painless upgrade, but is a very bad choice for new users, or anyone wanting
> to make comparisons between Cassandra versions or between Cassandra and other
> databases.
> We offer very little indication, in the database packaging itself, that there
> are well-tested configuration choices that can solve known problems and
> dramatically improve performance. This is guaranteed to paint the database in
> a worse light than it deserves, and will very likely hurt adoption.
> We should find a way to offer a very easy way of choosing between "optimized"
> and "compatible" defaults. At minimal, we could provide alternate yaml files.
> Alternatively, we could build on the {{storage_compatibility_mode}} concept
> to grow it into a setting that not only enables/disables certain settings,
> but also changes their default values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18753) Add an optimized default configuration to tests and make it available for new users
[
https://issues.apache.org/jira/browse/CASSANDRA-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821797#comment-17821797
]
Ekaterina Dimitrova edited comment on CASSANDRA-18753 at 2/28/24 6:01 PM:
--
[~blambov] , do we want to enable paxos v2 here by default?
Considering that we have a few failures also presented in 4.1, and that the
configuration to enable it is considered advanced and not even mentioned in
default Cassandra.yaml for those reasons, I think we might still want to not
enable it by default in the new config file for now. The Paxos v2 failures
discovered here also exist in 4.1; I just marked them as 5.0 non-blockers for
now.
was (Author: e.dimitrova):
[~blambov] , do we want to enable paxos v2 here by default?
Considering that we have a few failures also presented in 4.1 and that the
configuration to enable it is considered advanced and not even mentioned in
default cassandra.yaml for those reasons, I think we might want to still not
enable it by default in the new config file for now.
> Add an optimized default configuration to tests and make it available for new
> users
> ---
>
> Key: CASSANDRA-18753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18753
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Urgent
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> CCM_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch,
>
> DTEST_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch
>
> Time Spent: 11h
> Remaining Estimate: 0h
>
> We currently offer only one sample configuration file with Cassandra, and
> that file is deliberately configured to disable all new functionality and
> incompatible improvements. This works well for legacy users that want to have
> a painless upgrade, but is a very bad choice for new users, or anyone wanting
> to make comparisons between Cassandra versions or between Cassandra and other
> databases.
> We offer very little indication, in the database packaging itself, that there
> are well-tested configuration choices that can solve known problems and
> dramatically improve performance. This is guaranteed to paint the database in
> a worse light than it deserves, and will very likely hurt adoption.
> We should find a way to offer a very easy way of choosing between "optimized"
> and "compatible" defaults. At minimal, we could provide alternate yaml files.
> Alternatively, we could build on the {{storage_compatibility_mode}} concept
> to grow it into a setting that not only enables/disables certain settings,
> but also changes their default values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18753) Add an optimized default configuration to tests and make it available for new users
[
https://issues.apache.org/jira/browse/CASSANDRA-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799053#comment-17799053
]
Branimir Lambov edited comment on CASSANDRA-18753 at 1/16/24 8:49 AM:
--
Merged CCM and DTest patches (they do not change anything unless the
{{--configuration-yaml}} flag is used).
[The state of failing tests at the
moment|https://app.circleci.com/pipelines/github/blambov/cassandra/595/workflows/ed598605-6af6-443e-9336-aaa47ae27e43]:
- JUnit tests in compatible mode (which changes to use {{{}heap_buffers{}}}):
-- {{CQLVectorTest}} (CASSANDRA-19167)
-- {{VectorUpdateDeleteTest}} (CASSANDRA-19168)
- JUnit tests in latest mode:
-- repair fuzz tests {{{}ConcurrentIrWithPreviewFuzzTest{}}},
{{{}FailedAckTest{}}}, {{{}FailingRepairFuzzTest{}}},
{{{}HappyPathFuzzTest{}}}, {{SlowMessageFuzzTest}} (CASSANDRA-19042)
-- {{RepairJobTest}} (CASSANDRA-19043)
-- {{ClientRequestMetricsTest}} (CASSANDRA-19046)
- JVM dtests in latest mode:
-- {{RepairTest}} (CASSANDRA-19085)
-- {{SSTableLoaderEncyptionOptionsTest}} (CASSANDRA-19126)
-- {{QueriesTableTest}} (CASSANDRA-19046)
- Python dtests in latest mode:
-- {{TestWriteFailures.testPaxos}} (CASSANDRA-19145)
-- {{TestReplaceAddress}} (CASSANDRA-19144)
-- {{TestSnapshot}} (CASSANDRA-19126)
-- {{TestClientRequestMetrics}} (CASSANDRA-19046)
Several {{TestBootstrap}} tests seems to be failing in all configurations, some
already marked as flaky; this likely is not caused by this patch. There are
also some timeouts (e.g. {{ActiveCompactionsTest}} times out when run
repeatedly due to longer
{{{}testActiveCompactionTrackingRaceWithIndexBuilder{}}}).
Please review [the PR|https://github.com/apache/cassandra/pull/2896].
was (Author: blambov):
Merged CCM and DTest patches (they do not change anything unless the
{{--configuration-yaml}} flag is used).
[The state of failing tests at the
moment|https://app.circleci.com/pipelines/github/blambov/cassandra/595/workflows/ed598605-6af6-443e-9336-aaa47ae27e43]:
- JUnit tests in compatible mode (which changes to use {{{}heap_buffers{}}}):
-- {{CQLVectorTest}} (CASSANDRA-19167)
-- {{VectorUpdateDeleteTest}} (CASSANDRA-19168)
- JUnit tests in latest mode:
-- repair fuzz tests {{{}ConcurrentIrWithPreviewFuzzTest{}}},
{{{}FailedAckTest{}}}, {{{}FailingRepairFuzzTest{}}},
{{{}HappyPathFuzzTest{}}}, {{SlowMessageFuzzTest}} (CASSANDRA-19042)
-- {{RepairJobTest}} (CASSANDRA-19043)
- JVM dtests in latest mode:
-- {{RepairTest}} (CASSANDRA-19085)
-- {{SSTableLoaderEncyptionOptionsTest}} (CASSANDRA-19126)
-- {{QueriesTableTest}} (CASSANDRA-19046)
- Python dtests in latest mode:
-- {{TestWriteFailures.testPaxos}} (CASSANDRA-19145)
-- {{TestReplaceAddress}} (CASSANDRA-19144)
-- {{TestSnapshot}} (CASSANDRA-19126)
-- {{TestClientRequestMetrics}} (CASSANDRA-19046)
Several {{TestBootstrap}} tests seems to be failing in all configurations, some
already marked as flaky; this likely is not caused by this patch. There are
also some timeouts (e.g. {{ActiveCompactionsTest}} times out when run
repeatedly due to longer
{{{}testActiveCompactionTrackingRaceWithIndexBuilder{}}}).
Please review [the PR|https://github.com/apache/cassandra/pull/2896].
> Add an optimized default configuration to tests and make it available for new
> users
> ---
>
> Key: CASSANDRA-18753
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18753
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
>Reporter: Branimir Lambov
>Assignee: Branimir Lambov
>Priority: Urgent
> Fix For: 5.0-rc, 5.x
>
> Attachments:
> CCM_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch,
>
> DTEST_Add_support_for_specifying_the_name_of_the_file_to_use_as_cassandra_YAML_.patch
>
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> We currently offer only one sample configuration file with Cassandra, and
> that file is deliberately configured to disable all new functionality and
> incompatible improvements. This works well for legacy users that want to have
> a painless upgrade, but is a very bad choice for new users, or anyone wanting
> to make comparisons between Cassandra versions or between Cassandra and other
> databases.
> We offer very little indication, in the database packaging itself, that there
> are well-tested configuration choices that can solve known problems and
> dramatically improve performance. This is guaranteed to paint the database in
> a worse light than it deserves, and will very likely hurt adoption.
> We should find a way to offer a very easy way of choosing between "optimized"
> and "compatible" defaults. At minimal, we could provide alternate
