[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994266#comment-14994266
]
Aleksey Yeschenko commented on CASSANDRA-10401:
---
Committed as
[ff9b6bb973db7f6ebe650d909d24dcf5aebcfae5|https://github.com/apache/cassandra/commit/ff9b6bb973db7f6ebe650d909d24dcf5aebcfae5]
to 2.1 and merged with 2.2, thanks.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
> Fix For: 2.2.4, 2.1.12
>
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994253#comment-14994253
]
Paulo Motta commented on CASSANDRA-10401:
-
Basically the constants are not present on 2.1, that's why I only used them on
the 2.2 branch.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993593#comment-14993593
]
Paulo Motta commented on CASSANDRA-10401:
-
[~aweisberg] Fixed 2.2 tests. Thanks for catching that. I think it should be
ready now.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994157#comment-14994157
]
Ariel Weisberg commented on CASSANDRA-10401:
OK. One last question. You modified some existing test code to use the
constants for keyspace and cf name in the 2.1 branch. It looks like it was
referring to a keyspace/cf combo that didn't exist. The same code is in 2.2,
but you didn't end up changing that.
Is that because in 2.2 Keyspace1 has a Counter1 CF?
Otherwise +1 looks good to commit.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992141#comment-14992141
]
Jim Witschey commented on CASSANDRA-10401:
--
The dtest results look right to me too. +1.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990511#comment-14990511
]
Ariel Weisberg commented on CASSANDRA-10401:
testall in 2.2 has a failing test. 2.1 looks good. I think there was no impact
on the dtests.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988490#comment-14988490
]
Paulo Motta commented on CASSANDRA-10401:
-
bq. Is there a test?
Added [simple
test|https://github.com/apache/cassandra/commit/21410a239d77a0e3c95c4ec35ec0d22b06cade1c]
checking for {{IllegalArgumentException}} when invalid ks/cf pair is specified.
bq. The only bike shedding I have is that if
ArrayBackedSortedColumns.factory.create() returns null why not check the output
of that instead instead of checking via a different path? Is this implying that
maybe ColumnFamily.Factory should be the the component that throws a more
reasonable exception?
I think it's better to add an explicit check for schema existence before trying
to instantiate an ArrayBackedSortedColumns, which is an internal class that
assumes the ks/cf exists (a similar check is done in other tools).
Tests will be available shortly below:
||2.1||2.2||
|[branch|https://github.com/apache/cassandra/compare/cassandra-2.1...pauloricardomg:10401-2.1]|[branch|https://github.com/apache/cassandra/compare/cassandra-2.2...pauloricardomg:10401-2.2]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-10401-2.1-testall/lastCompletedBuild/testReport/]|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-10401-2.2-testall/lastCompletedBuild/testReport/]|
|[dtests|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-10401-2.1-dtest/lastCompletedBuild/testReport/]|[dtests|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-10401-2.2-dtest/lastCompletedBuild/testReport/]|
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987558#comment-14987558
]
Ariel Weisberg commented on CASSANDRA-10401:
Our process is normally that an assignee fixing the issue will also add the
regression test so that the work is "done." The only exception I make is for
infrequent or new outside contributors or extenuating circumstances.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986118#comment-14986118
]
Ariel Weisberg commented on CASSANDRA-10401:
Being the devilishly insightful reviewer that I am I have to ask. Is there a
test?
The only bike shedding I have is that if
ArrayBackedSortedColumns.factory.create() returns null why not check the output
of that instead instead of checking via a different path? Is this implying that
maybe ColumnFamily.Factory should be the the component that throws a more
reasonable exception?
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986226#comment-14986226
]
Jim Witschey commented on CASSANDRA-10401:
--
I haven't written a test; unless I'm told otherwise I'm going to put this
behind 3.0 work until 3.0 is released. If someone else can get to it first,
feel free to assign yourself as Tester.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>Assignee: Paulo Motta
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941294#comment-14941294
]
Jim Witschey commented on CASSANDRA-10401:
--
Glad it worked.
This should have better error reporting; I've renamed the issue to reflect that.
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-10401) Improve json2sstable error reporting on nonexistent column
[
https://issues.apache.org/jira/browse/CASSANDRA-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14941304#comment-14941304
]
Jose Martinez Poblete commented on CASSANDRA-10401:
---
Perhaps the command could come up with a better error message?
> Improve json2sstable error reporting on nonexistent column
> --
>
> Key: CASSANDRA-10401
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10401
> Project: Cassandra
> Issue Type: Bug
> Components: Tools
> Environment: Cassandra 2.1.8.621
>Reporter: Jose Martinez Poblete
>
> We have the following table...
> {noformat}
> CREATE TABLE keyspace_name.table_name (
> col1 text,
> col2 text,
> col3 text,
> col4 text,
> PRIMARY KEY ((col1, col2), col3)
> ) WITH CLUSTERING ORDER BY (col3 ASC)
> {noformat}
> And the following json in a file created from sstable2json tool
> {noformat}
> [
> {"key": "This is col1:This is col2,
> "cells": [["This is col3:","",1443217787319002],
>["This is col3:"col4","This is col4",1443217787319002]]}
> ]
> {noformat}
> Let's say we deleted that record form the DB and wanted to bring it back
> If we try to create an sstable from this data in a json file named
> test_file.json, we get a NPE
> {noformat}
> -bash-4.1$ json2sstable -K elp -c table_name-3264cbe063c211e5bc34e746786b7b29
> test_file.json
> /var/lib/cassandra/data/keyspace_name/table_name-3264cbe063c211e5bc34e746786b7b29/keyspace_name-table_name-ka-1-Data.db
> Importing 1 keys...
> java.lang.NullPointerException
> at
> org.apache.cassandra.tools.SSTableImport.getKeyValidator(SSTableImport.java:442)
> at
> org.apache.cassandra.tools.SSTableImport.importUnsorted(SSTableImport.java:316)
> at
> org.apache.cassandra.tools.SSTableImport.importJson(SSTableImport.java:287)
> at org.apache.cassandra.tools.SSTableImport.main(SSTableImport.java:514)
> ERROR: null
> -bash-4.1$
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
